fluent-bit-docs icon indicating copy to clipboard operation
fluent-bit-docs copied to clipboard

Make the 3.1 notes more prominent in kubernetes-events.md as this is a breaking change

Open douglasawh opened this issue 1 year ago • 3 comments

This is a pretty massive change in the way the plugin works. Sticking this at the bottom in a foot note does not seem appropriate.

The decision to do this initially does make some sense, as 3.1 is not going to be the version that everyone is using. However, over time, this will come to be the dominant behavior, and that behavior should be made clear to the users.

douglasawh avatar Aug 29 '24 14:08 douglasawh

Hi @douglasawh, thanks for your submission. Could you please review our contributing guidelines and adhere to them? After that, we'll gladly merge your contribution.

Thanks

lecaros avatar Aug 30 '24 21:08 lecaros

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Nov 29 '24 02:11 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Jun 24 '25 02:06 github-actions[bot]

@douglasawh can you please fix the conflicts here so I can merge for you?

eschabell avatar Oct 21 '25 14:10 eschabell

The conflicts were due to formatting changes for style, I went ahead and fixed the conflicts in the interest of keeping things moving.

esmerel avatar Oct 21 '25 18:10 esmerel

The DCO failure is a hard block

patrick-stephens avatar Oct 21 '25 19:10 patrick-stephens

@douglasawh if you can look at the DCO failures, we've pushed through the original conflicts for you, would love to have this PR in a clean state to merge?

eschabell avatar Nov 04 '25 14:11 eschabell