fluent-bit-docker-image icon indicating copy to clipboard operation
fluent-bit-docker-image copied to clipboard

[docker] Use cc-debian11 for distroless base image

Open anouarchattouna opened this issue 4 years ago • 9 comments

Using gcr.io/distroless/cc-debian11 instead of gcr.io/distroless/cc-debian10 Using LABEL instead of MAINTAINER (deprecated)

anouarchattouna avatar Oct 20 '21 13:10 anouarchattouna

@edsiper are you OK with that ?

PascalBourdier avatar Nov 16 '21 15:11 PascalBourdier

Hi @PascalBourdier @edsiper, is this PR ready to merge? Thanks!

antoniomrfranco avatar Dec 09 '21 14:12 antoniomrfranco

@edsiper can you merge this, please?

anouarchattouna avatar Jan 19 '22 14:01 anouarchattouna

Adding @patrick-stephens

agup006 avatar Jan 20 '22 17:01 agup006

Yeah the main repo ones have been updated but I raised an issue on sorting the labels out similar to here. I also modified the maintainer email.

We probably should update the busy box version here and I think I had to make a tweak to the location of some system libraries.

I'm not sure what the longer term plan is for this repo plus there is a bit of a delta between master and the 1.8 branch we probably should sort.

patrick-stephens avatar Jan 20 '22 18:01 patrick-stephens

@patrick-stephens if I am not wrong this also needs other adjustment rights ? (systemd)

edsiper avatar Jan 20 '22 19:01 edsiper

Yeah there was a bit of a delta between what is on master and the 1.8 branch here. For those other changes for the ARM images to be backported to 1.8 I used the 1.8 branch. They also did not want a Debian base image update.

The changes I made to get a working Debian 11 container are all on: https://github.com/fluent/fluent-bit/pull/4516/files Specifically for this file (rather than the ARM ones):

  • Remove the buster-backports for systemd (we're wanting the latest bullseye ones) as you say: https://github.com/fluent/fluent-bit/blob/938a53b9337b1a2bb9dcb8636dfa75f49a51b0ce/dockerfiles/Dockerfile.x86_64#L28
  • Additional dependencies need copying for libgcrypt (this is the problem with doing direct library copying): https://github.com/fluent/fluent-bit/blob/938a53b9337b1a2bb9dcb8636dfa75f49a51b0ce/dockerfiles/Dockerfile.x86_64#L80

I did do some other general improvements highlighted during linting as well. I'm afraid I was not aware of this repo at that point and when I looked to do the 1.8 backporting of the systemd updates I targeted them at that specific branch. Master currently seems to have 1.7 variables in it which is a bit confusing too.

patrick-stephens avatar Jan 20 '22 19:01 patrick-stephens

@niedbalski can probably confirm or correct me but I believe the plan is to deprecate this repository from the 1.9 release series?

patrick-stephens avatar Jan 20 '22 19:01 patrick-stephens

@patrick-stephens correct, ideally changes should go upstream now on, the plan is to archive this repository from 1.9 ongoing and all changes has to be synced in the fluent/fluent-bit repository. For the OCI labels I think you're addressing those on #4636 and debian11 has been updated across on https://github.com/fluent/fluent-bit/blob/9ef9d6d7dcea9a97c38dac806c29e867a8d9f793/dockerfiles/Dockerfile.multiarch

niedbalski avatar Jan 20 '22 22:01 niedbalski