fluent-plugin-bigquery icon indicating copy to clipboard operation
fluent-plugin-bigquery copied to clipboard

Bug in retry logic ?

Open Elyahou opened this issue 3 years ago • 0 comments

I can see here:

https://github.com/fluent-plugins-nursery/fluent-plugin-bigquery/blob/b86cce93b57712c641cf5e37c6733ee88a269cff/lib/fluent/plugin/out_bigquery_insert.rb#L100-L105

If I understand correctly the code here, in case of bigquery insert error, it is checked if the error is retryable, and only if it is not, do a retry...

Should'nt it the inverse ? And retry only if it is retryable ?

Elyahou avatar Feb 02 '22 10:02 Elyahou