dev-rewards icon indicating copy to clipboard operation
dev-rewards copied to clipboard

give local .bin higher priority

Open phryneas opened this issue 1 year ago • 1 comments

There are other binaries available called sha3sum (e.g. as part of busybox).

As a result, those will be executed, and while they throw an error, that error will be swallowed because of the sha3sum || true call.

As a result, you get a completely wrong hash in the end end well, dig for the reason for quite a while.

This PR will prioritize the downloaded binary over any system binary.

Tbh., I would also recommend removing that || true - it's bound to bring more problems than it solves.

phryneas avatar Mar 10 '24 16:03 phryneas

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 10 '24 16:03 CLAassistant

Nice, thanks! Agree with removing || true.

akim-bow avatar Mar 14 '24 03:03 akim-bow