Floris Bruynooghe
Floris Bruynooghe
Best would be to find someone who is interested in properly maintaining this, and preferably out of the main repo like flatpak is imho. I was only playing with it...
> * The one exception is Provider, since this gives out `'static` references, so I can't allocate the newtype anywhere. There's a `dc_provider_unref` (that's currently a no-op) so that's a...
what if you kept `dc_accounts_event_emitter_t` and its functions but they are just aliases for `dc_event_emitter_t`. could we achieve the same without breaking the ffi?
For a non-secure-join we could be concerned about someone changing the first message from bob to alice. In which case we need to run a full setup-contact flow first, after...
https://github.com/deltachat/deltachat-core-rust/blob/8f8db0c43108e8a9386f89df23bee7ed45836a3f/src/securejoin.rs#L602 is problematic. The problem is that for bob to know alice is verified in the verified-group protocol alice needs to send a signed & encrypted vg-member-added. But instead we...
A very rough note: the claims to this being correct mean that the https://github.com/deltachat/deltachat-core-rust/blob/8f8db0c43108e8a9386f89df23bee7ed45836a3f/src/securejoin.rs#L626 line is sufficient to verify alice and even that this can be done in the vg-member-added...
> Regarding Note3, however, i think we need to modify > https://github.com/deltachat/deltachat-core-rust/blob/master/src/securejoin.rs#L614 > to ensure if the message is encrypted that it is signed with alice's proper key. I think...
I believe the discussion at https://github.com/nextleap-project/countermitm/issues/83 points out that when we do *not* check whether `vc-contact-confirm`|`vg-member-added` is signed&encrypted Bob can only mark Alice as uni-directionally verified and not as bi-directionally...
Just a quick note I'm looking at finally resolving this. I'm investigating introducing a non-user-visible `UnidirectionalVerified` status (or rather start using the existing one). I'll try and describe the effect...
So here's my proposal, I've thought through this by now and think this works. Given this current definition of a contact: ``` #[derive(Debug, PartialEq, Eq, Clone, Copy, FromPrimitive)] #[repr(u8)] pub...