gatsby-plugin-gtag Made the changes requested for pull request #19

Made the changes requested for pull request #19

Open magp3 opened this issue 5 years ago • 4 comments

Made based on the changes submitted by @atomicpages issue #18

Mar 12 '20 03:03 magp3

Any idea when this will be merged?

Sep 23 '20 08:09 jonny-harte

@jonny-harte I have no idea but in the meantime you could load it yourself, as a local plugin.

https://www.gatsbyjs.com/docs/loading-plugins-from-your-local-plugins-folder/

Sep 24 '20 03:09 magp3

Please address that comment – https://github.com/flpvsk/gatsby-plugin-gtag/pull/19#discussion_r382800319

I'd suggest to remove the whole createFunctionWithTimeout and leave it up to the user to wrap the callback with setTimeout if they need to.

Sep 24 '20 08:09 flpvsk

Thanks @magp3 I'll look at that as a temporary solution. Are you not able to address @flpvsk comment?

Oct 02 '20 17:10 jonny-harte