angular-underscore icon indicating copy to clipboard operation
angular-underscore copied to clipboard

Consider a bower package?

Open fraserxu opened this issue 11 years ago • 10 comments

I've been using this in my project, but we are using bower as the package manager. Have you consider to make it installable through bower?

BTW, in order to use this, I also have to include underscore in my bower.json file, I want something like angular-underscore in my json file, thanks!

fraserxu avatar Dec 06 '13 08:12 fraserxu

I've added bower.json without testing, would you mind to test it?

And since considering Lo-Dash, the decision of underscore or Lo-Dash as the infrastructure is remained with users, i.e., you can include 'underscore' or 'lodash', depends on you .

floydwch avatar Dec 06 '13 09:12 floydwch

If you say so, why not have another one named angular-lodash. The name would be confusing if you let people choose which library to use, no?

fraserxu avatar Dec 06 '13 09:12 fraserxu

@fraserxu Because Lo-Dash is as a drop-in replacement for underscore, if include underscore directly in this package, one can't have other choice for consideration, so leave it for users might be better.

Also, this package's description is "Underscore adapter for AngularJS", i.e., it's just an adapter, not an implementation of underscore.

floydwch avatar Dec 06 '13 10:12 floydwch

@floydsoft I've tested installing ver. 0.4.0 but I have this error in return:

bower angular-underscore#~0.4.0     ENORESTARGET No tag found that was able to satisfy ~0.4.0

sentenza avatar Dec 21 '13 11:12 sentenza

Indeed. Tagging the releases would be nice. But in the meantime just do bower angular-underscore it'll check out the master.

bower info angular-underscore

Zmetser avatar Dec 21 '13 13:12 Zmetser

Yes, I already did that to fix the dependency.

sentenza avatar Dec 21 '13 13:12 sentenza

@sentenza You can only try install it directly without adding the version.

fraserxu avatar Dec 22 '13 06:12 fraserxu

+1 for tagging the version - my webapp stopped working because of the fact, that angular-underscore was updated to latest version, while I had older version of underscore in bower.

tomaszkrym avatar Oct 23 '14 22:10 tomaszkrym

@tomaszkrym I added the tag v0.5.0, could you mind to test for it?

floydwch avatar Oct 25 '14 09:10 floydwch

@floydsoft it works fine, thanks!

tomaszkrym avatar Oct 26 '14 18:10 tomaszkrym