serverless-esbuild icon indicating copy to clipboard operation
serverless-esbuild copied to clipboard

Indirect dependency marked as external missing in package

Open jer-sen opened this issue 2 years ago • 1 comments

Describe the bug My code import a module ssh2-sftp-client which has module ssh2 as a dependency which is listed in esbuild.config.ts externals (contains .node files). ssh2 is in .esbuild/.build folder but missing in final zip package.

To Reproduce Add dependencies ssh2-sftp-client and ssh2, add ssh2 to externals, and package a file importing ssh2-sftp-client.

Expected behavior ssh2 present in package.

Screenshots or Logs NA

Versions (please complete the following information):

Additional context Is ssh2 is imported from directly from the file importing ssh2-sftp-client, then everything is ok. That's my workaround...

jer-sen avatar Dec 07 '23 16:12 jer-sen

ok im hitting this too now, externals is being ignored or something

a-r-d avatar May 09 '24 19:05 a-r-d