serverless-esbuild icon indicating copy to clipboard operation
serverless-esbuild copied to clipboard

Published 20 hours ago • verified publisher icon floydspace

feat: exclude third level dependencies

Open deathemperor opened this issue 1 year ago • 5 comments

addresses https://github.com/floydspace/serverless-esbuild/issues/312

deathemperor avatar Aug 08 '23 13:08 deathemperor

@floydspace can you have a look at this please? I still have to use patching for this with my deployment

deathemperor avatar Oct 12 '23 16:10 deathemperor

Hey @deathemperor Last time I checked, the tests were failing, and it is still the case, could you please fix tests here is the error from Ci Expected '!==' and instead saw '!='

floydspace avatar Oct 12 '23 16:10 floydspace

@floydspace I've updated the code, can you run the tests again please? thanks.

deathemperor avatar Oct 16 '23 02:10 deathemperor

still wish to have this done, any idea what preventing it from getting merged @floydspace ?

deathemperor avatar Mar 08 '24 02:03 deathemperor

Curious about this PR and whether it would help us reduce the zip size when comparing the zip generated by serverless-webpack vs serverless-esbuild.

I can't see which tests are failing, but I assume that is the main thing preventing this PR from moving forward to code review?

danrivett avatar Apr 11 '24 03:04 danrivett