feat: support non-semver versions in the yarn packager, for example 'github:' references
feat: support non-semver versions in the yarn packager, for example 'github:' references, when their parent package is marked 'external'.
Issue here
- Don't assume the format
<name>@<semver>. Use a regex that also returns the correct package name for this format:
@org/package@git+ssh://[email protected]/org/package#tag
(The last @ in this case is part of the URL and does not denote the boundary between package name and version).
- If the version is not valid semver, optimistically include the package in the yarn packager results, as it may be a github reference for e.g. where semver doesn't always apply.
I verified this fixes the problem in my minimal test repo here, but I'm not sure if this will have unintended side effects. Needs further testing.
Hi @flipscholtz . I run the tests for the feature, and they failed, could have a look
and is it applyed only for yarn? should it also be implemented for npm and pnpm?
Hi @flipscholtz . I run the tests for the feature, and they failed, could have a look and is it applyed only for
yarn? should it also be implemented fornpmandpnpm?
Hi @floydspace I pushed a fix for the tests, they are passing for me now. I am looking at npm and pnpm, will update asap.