react-native-home-indicator
react-native-home-indicator copied to clipboard
AppDelegate.mm install instructions for RN 0.71
RN 0.71 seems to have changed the AppDelegate entrypoint significantly. From piecing together info from
https://github.com/facebook/react-native/issues/35937
and
https://github.com/facebook/react-native/blob/main/Libraries/AppDelegate/RCTAppDelegate.h
I think the correct way to install, replacing the default UIViewController would be to add a new method override like so:
- (UIViewController *)createRootViewController
{
return [HomeIndicatorViewController new];
}
does that seem correct to you? if so, would you be open to a PR to modify the readme?
Hi @jaredh159
Have you found a solution to the integration problem ?
I tried to use your sample code, but after building on iOS, the app crashes without errors.
the code i showed above is working for me. i'm guessing maybe your crash has to do with something else? make sure you've also added:
#import <RNHomeIndicator.h>
RN 0.71 seems to have changed the AppDelegate entrypoint significantly. From piecing together info from
and
https://github.com/facebook/react-native/blob/main/Libraries/AppDelegate/RCTAppDelegate.h
I think the correct way to install, replacing the default UIViewController would be to add a new method override like so:
- (UIViewController *)createRootViewController { return [HomeIndicatorViewController new]; }
does that seem correct to you? if so, would you be open to a PR to modify the readme?
Updated location on github for those whore interested https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/AppDelegate/RCTAppDelegate.mm#L127
I was experiencing build issues using the recommended install steps on RN 0.71.X. The method mentionned here allowed me to build and fix the problems
Thanks a lot!