the-graph icon indicating copy to clipboard operation
the-graph copied to clipboard
verified publisher icon flowhub

Error when removing graph

Open bergie opened this issue 8 years ago • 3 comments

When you set the graph of the-graph-editor to NULL (for example, when navigating away from a graph in noflo-ui), we get an error:

screenshot 2017-02-23 at 12 23 43

bergie avatar Feb 23 '17 11:02 bergie

I suspect there are other things broken in this case also, like stale state in component library etc. As far as I know, noflo-ui used to just swap the entire widget, right?

jonnor avatar Feb 23 '17 14:02 jonnor

@jonnor nope, we keep one widget and change graph. Current master of noflo-ui keeps the last-seen graph in state until a new one is provided, which causes occasional funkiness. This is fixed in noflo/noflo-ui#680, but that unfortunately causes this issue with the-graph-editor

bergie avatar Feb 23 '17 15:02 bergie

I'm tempted to consider graph property mandatory, and close this as wont-fix - unless there is an important usecase for it.

jonnor avatar Aug 17 '17 14:08 jonnor