flowdock-api
flowdock-api copied to clipboard
Git-aware notification does not work if branch not defined
I've purposefully not set :branch in my Capfile, to be able to deploy the currently checked out branch. This causes notifications to fail, however, wth
triggering after callbacks for `deploy'
* 2013-10-15 10:47:00 executing `flowdock:notify_deploy_finished'
triggering before callbacks for `flowdock:notify_deploy_finished'
* 2013-10-15 10:47:00 executing `flowdock:set_flowdock_api'
Flowdock: error in sending notification to your flow: undefined local variable or method `branch' for #<Capistrano::Configuration::Namespaces::Namespace:0x007fcff24d2168>
* 2013-10-15 10:47:00 executing `flowdock:save_deployed_branch'
* executing "echo 'HEAD' > /path/to/myapp/current/BRANCH"
I think the process should be smart enough to git rev-parse --abbrev-ref HEAD if the branch has not been given.
@ilkka I've since moved on to capistrano 3, but can you check if the problem persists in this branch?
Gemfile excerpt:
gem 'flowdock', github: 'blackxored/flowdock-api', branch: 'fix-undefined-branch'