flowable-engine icon indicating copy to clipboard operation
flowable-engine copied to clipboard

Add all the things to javadocs

Open aaronkavlie-wf opened this issue 8 years ago • 5 comments

Some important packages are missing from the javadocs. For one example, there is no org.flowable.engine.impl. Everything under org.flowable.engine ought to be included.

aaronkavlie-wf avatar May 17 '17 19:05 aaronkavlie-wf

I believe that this because may not be exactly clear as to the intended audience for the JavaDocs. Is the JavaDoc for users of Flowable or for developers working on the Flowable code base?

Given statements such as the following in the User Doc it would reason that org.flowable.engine.impl would not be included and the audience is Flowable users.

1.7. Internal implementation classes

In the JAR files, all classes in packages that have .impl. (e.g. org.flowable.engine.impl.db) in their name are implementation classes and should be considered internal use only. No stability guarantees are given on classes or interfaces that are in implementation classes.

dbmalkovsky avatar May 23 '17 14:05 dbmalkovsky

A number of impl classes have made their way into our code (at least, our test code), such as org.flowable.engine.impl.cfg.StandaloneProcessEngineConfiguration. The docs encourage usage of other code in there too, such as org.flowable.engine.impl.bpmn.listener.ScriptTaskListener & org.flowable.engine.impl.history.HistoryLevel.

aaronkavlie-wf avatar May 23 '17 15:05 aaronkavlie-wf

There are other packages missing as well — org.flowable.idm and org.flowable.bpmn, for example. These packages include types returned by prominent public API methods.

aaronkavlie-wf avatar May 23 '17 16:05 aaronkavlie-wf

Missing Javadocs is an impediment to getting up to speed with Flowable. For instance, the method TaskService.getIdentityLinksForTask() returns List<org.flowable.identitylink.api.IdentityLink> which I believe is out of bounds as far as Javadocs go. There used to be an IdentityLinkType, but now it seems to be an arbitrary string. -- These are not questions to be answered here. It is an example of little things that one should be able to find out on one's own.

namgang avatar Feb 25 '18 10:02 namgang

I agree that javadocs should be made up to date it makes it easier not only for users to understand the product but also for open source contributors.

darkmastermindz avatar Aug 17 '23 18:08 darkmastermindz