flowable-engine icon indicating copy to clipboard operation
flowable-engine copied to clipboard

dependency scope setting issues

Open DataProvided opened this issue 3 years ago • 1 comments

Hi,

We are developing a tool to check whether the dependencies' scopes in maven are set rightly and reasonably.

Our tools have found some issues in your project about scope setting in maven' pom.xml file.

  • in modules\flowable-spring-security\pom.xml, org.springframework.security:spring-security-core scope should be compile instead of provided.
  • in modules\flowable-job-service\pom.xml, javax.enterprise.concurrent:javax.enterprise.concurrent-api scope should be compile instead of provided.
  • in modules\flowable-cmmn-engine\pom.xml, org.slf4j:jcl-over-slf4j scope should be compile instead of test.

Please help us confirm whether the above reports are right and explain why it should set like these.

Thanks a lot.

DataProvided avatar Apr 13 '22 12:04 DataProvided

Thanks for the feedback, can you maybe share more information why this came out of the tool that you are developing? For example, the first one about spring-security-core looks correct, but the jcl-over-slf4j dependency not.

tijsrademakers avatar Apr 19 '22 06:04 tijsrademakers