flowable-engine icon indicating copy to clipboard operation
flowable-engine copied to clipboard

UI Modeler cannot import reactivate event listener

Open aplatakis opened this issue 3 years ago • 2 comments

Issue: It is not possible to import reactivate event listener in modeler UI. If cmmn diagram contains such element, then after import it is dropped and is not present in UI Modeler UI not allows to add reactivate event listener using UI

Cause: Reactivate event listener do not have json converter implemented.

Details: Reactivate event listener is using the same tag "EventListener" as generic event listener. EventType="reactivate" is used to configure it as reactivate event listener

Solution:

  • New stencil id introduced for reactivate listener
  • For reactivate event listener to import registered new json converter which maps listener to "ReactivateEventListener" stencilId.
  • For event registry support reactivation event listener can accept eventType. After this request will be accepted, other pull request will be posted for event registry support

Check List:

  • Unit tests: NA
  • Documentation: NA

aplatakis avatar Jan 27 '22 09:01 aplatakis

Thanks for the PR, but for the reactivate event listener a dedicated element type would be needed, so not sharing it with a generic event listener. Would that be something you would be willing to work on?

tijsrademakers avatar Feb 09 '22 12:02 tijsrademakers

@tijsrademakers thanks for review. First idea was to use new element type, but when I realized that I would need to introduce new icon for that, I dropped the idea. But I do agree that new element type would be better as this would drop not needed configuration options in UI, bring more clarity in UI and code and so on. I will change my code to use new element type I have question regarding languages support. Is it enough to add localized values only for en? Will this not cause issues for other existing languages? As I'm not sure that google translate is the best option here.. For some languages I see that not all UI elements are translated

aplatakis avatar Feb 09 '22 12:02 aplatakis

Closing because Modeler is not part of Flowable 7 codebase.

tijsrademakers avatar Oct 09 '23 06:10 tijsrademakers