flow icon indicating copy to clipboard operation
flow copied to clipboard

DQN for flow

Open pengyuan-zhou opened this issue 4 years ago • 8 comments

Hi,

This is a branch to enable DQN (also by ray) for flow. Currently it supports single agent and multi-agent tests on traffic_light_grid scripts.

Other examples can be easily enabled by modifying corresponding example file, env file and test file, according to the modifications in this branch.

Cheers, Pengyuan

pengyuan-zhou avatar Jun 11 '20 19:06 pengyuan-zhou

Ya I have zero ideas why the build fails, it works on my pc (without the unittest).

pengyuan-zhou avatar Jun 12 '20 10:06 pengyuan-zhou

Putting aside the build failure, this sets RLlibs DQN as the default option. We'd prefer you make it so that there's a choice of algorithm, of which DQN is one. You can look at train.py in the flow_maddpg branch for an example.

eugenevinitsky avatar Jun 19 '20 16:06 eugenevinitsky

Putting aside the build failure, this sets RLlibs DQN as the default option. We'd prefer you make it so that there's a choice of algorithm, of which DQN is one. You can look at train.py in the flow_maddpg branch for an example.

Sure, I'll revise it. BTW in that train.py, is the TD3 in setup_exps_rllib same with the one in h-baseline?

pengyuan-zhou avatar Jun 19 '20 17:06 pengyuan-zhou

Putting aside the build failure, this sets RLlibs DQN as the default option. We'd prefer you make it so that there's a choice of algorithm, of which DQN is one. You can look at train.py in the flow_maddpg branch for an example.

Hi Eugene, I've modified the code according to mappdg's fashion. Cheers.

pengyuan-zhou avatar Jun 22 '20 10:06 pengyuan-zhou

Well, not quite. The implementation of TD3 in h-baselines is not identical to the rllib one.

eugenevinitsky avatar Jun 22 '20 22:06 eugenevinitsky

This looks good to me minus comments! @pengyuan-zhou if the changes are made I will merge.

eugenevinitsky avatar Sep 07 '20 15:09 eugenevinitsky

@AboudyKreidieh @kanaadp @kjang96

pengyuan-zhou avatar May 28 '23 03:05 pengyuan-zhou

Hey! I'm really sorry about the state of things here, we are working on getting a new maintainer in the next week or so so this doesn't happen again.

eugenevinitsky avatar Jun 03 '23 23:06 eugenevinitsky