flow icon indicating copy to clipboard operation
flow copied to clipboard

Configurable setup of arguments to pass to SUMO executable

Open roireshef opened this issue 4 years ago • 2 comments

Feature Description

Please provide:

flow.core.kernel.simulation.traci.TraCISimulation has start_simulation method that spawns a SUMO instance. The configuration of arguments passed to the sumo instance is not exposed to the developer, and we need to go and change library code, which is not a good practice IMHO. Just like:

            # command used to start sumo
            sumo_call = [
                sumo_binary, "-c", scenario.cfg,
                "--remote-port", str(sim_params.port),
                "--num-clients", str(sim_params.num_clients),
                "--step-length", str(sim_params.sim_step)
            ]

I suggest movinga any and all SUMO executable parameters to some default configuration class (SimParams would be a good candidate) and expose it to users.

Thanks!

roireshef avatar May 24 '20 07:05 roireshef

Oh yeah, this is a good idea!

eugenevinitsky avatar May 25 '20 03:05 eugenevinitsky

Anyone working on that? Is there any expected timeframe?

roireshef avatar May 30 '20 11:05 roireshef