flow icon indicating copy to clipboard operation
flow copied to clipboard

Lane area detectors

Open vallout opened this issue 5 years ago • 7 comments

Pull request information

  • Status: ready to merge
  • Kind of changes: new feature

Description

While creating a network template now it can be added a file with the key-word "det". This makes it possible to add lane area detectors to the network (it should be added the ability to add all detectors) and use them for training. Only applicable to sumo simulations, yet.

vallout avatar Dec 16 '19 15:12 vallout

Pull Request Test Coverage Report for Build 4898

  • 60 of 122 (49.18%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 90.417%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flow/core/kernel/network/traci.py 1 5 20.0%
flow/networks/base.py 3 15 20.0%
flow/core/kernel/lane_area_detectors/traci.py 37 83 44.58%
<!-- Total: 60 122
Totals Coverage Status
Change from base Build 4853: -0.5%
Covered Lines: 9313
Relevant Lines: 10300

💛 - Coveralls

coveralls avatar Dec 16 '19 18:12 coveralls

Thank you for this contribution! I'm currently flying but will review this once I land!

eugenevinitsky avatar Dec 17 '19 04:12 eugenevinitsky

Thanks so much for this! Could you add an example of its usage?

eugenevinitsky avatar Dec 23 '19 15:12 eugenevinitsky

Hi, any reason for delay in merging this PR. I wanted to use this feature so happy to help with this. If needed I can also help integrating the induction loop detector as well. Thanks.

parthjaggi avatar Apr 01 '20 03:04 parthjaggi

Oh wow I didn't see how complete this is. You can obviously just grab the branch now but unfortunately we need to write tests for this to merge it into master (well, someone needs to write unit tests).

eugenevinitsky avatar Apr 01 '20 03:04 eugenevinitsky

There's even a tutorial! Amazing job @vallout

eugenevinitsky avatar Apr 01 '20 03:04 eugenevinitsky

Thanks, the tutorial is a little clunky, but I tried... And after the patch arround new year, the code didn't pass the tests. So I assume, that it is a little outdated. BR :-)

vallout avatar Apr 01 '20 07:04 vallout