flow icon indicating copy to clipboard operation
flow copied to clipboard

Libsumo

Open AboudyKreidieh opened this issue 5 years ago • 4 comments

Pull request information

  • Status: in development
  • Kind of changes: new feature
  • Related PR or issue: resolves #35

Description

This PR adds support for libsumo, which greatly improves runtimes. This also comes with a new set of setup instructions. The average runtime of the benchmarks across ten runs before and after are as follows:

bottleneck0:
libsumo : 6.81 +/- 0.2
traci   : 20.1 +/- 0.7
improve : 2.95x

bottleneck1:
libsumo : 6.63 +/- 0.2
traci   : 18.8 +/- 1.0
improve : 2.84x

bottleneck2:
libsumo : 14.0 +/- 0.2
traci   : 38.4 +/- 1.3
improve : 2.74x

figureeight012:
libsumo : 1.20 +/- 0.09
traci   : 4.40 +/- 0.11
improve : 3.67x

grid0:
libsumo : 1.65 +/- 0.05
traci   : 4.95 +/- 0.03
improve : 3.00x

grid1:
libsumo : 3.98 +/- 0.1
traci   : 10.0 +/- 0.1
improve : 2.51x

merge012:
libsumo : 0.47 +/- 0.03
traci   : 3.18 +/- 0.20
improve : 6.77x

AboudyKreidieh avatar Jul 11 '19 06:07 AboudyKreidieh

Dang this is amazing and exciting. What a boss, Aboudy!

Best wishes, Cathy

cathywu avatar Jul 11 '19 07:07 cathywu

So uh, this passes. Can we merge it @AboudyKreidieh ?

eugenevinitsky avatar Aug 12 '19 21:08 eugenevinitsky

Pull Request Test Coverage Report for Build 4375

  • 56 of 81 (69.14%) changed or added relevant lines in 9 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 91.829%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flow/core/kernel/scenario/traci.py 17 18 94.44%
flow/envs/bottleneck_env.py 0 1 0.0%
flow/envs/base_env.py 3 5 60.0%
flow/core/kernel/traffic_light/traci.py 9 15 60.0%
flow/core/kernel/vehicle/traci.py 19 25 76.0%
flow/core/kernel/simulation/traci.py 5 14 35.71%
<!-- Total: 56 81
Files with Coverage Reduction New Missed Lines %
flow/envs/base_env.py 1 74.24%
<!-- Total: 1
Totals Coverage Status
Change from base Build 4369: -0.1%
Covered Lines: 9170
Relevant Lines: 9986

💛 - Coveralls

coveralls avatar Sep 04 '19 04:09 coveralls

Hi @AboudyKreidieh @eugenevinitsky - what's the status of migration to libsumo? Can this be pushed to master?

roireshef avatar Apr 13 '21 10:04 roireshef