Florent Vilmart

@rochdev , if I recap, in order to use diagnostics_channels, we need to implement the event handling through async storage. We cannot currently properly implement async_storage as we're missing an...

Oh great! Thanks @rochdev ; let me see how I can get this implemented.

@rochdev , I'm curious; and perhaps the current implementation is completely wrong, but given that this implementation keeps a WeakMap of `Request -> Spans`, isn't it circumventing this problem by...

Thanks a lot @rochdev for taking the time for this explanation! I concur that monkey patching is more straightforward then! Let me reevaluate both approaches.

@rochdev no problem! All's good; I did not realize we were missing so many events.

@artur-ma sure, this doesn't include body reading probably it would need it's own span outside of the request span. What do you think? I'm saying outside, as some users may...

@artur-ma that seems reasonable. I'm still on the fence about the monkey patching vs intrumentation with channels. I haven't had the chance to go back to it.

With regards to the recent announcement that undici's fetch would be integrated in node as experimental. I believe it makes sense I wrap first the fetch implementation through patching, without...

Gotcha!

@rochdev I believe I made some strides in the right direction: - calls are now wrapped - we use diagnostics channels in order to - inject span with all the...