Florent Vilmart
Florent Vilmart
This is not supported at the moment and would likely require a refactor on parse-server. Do you want to open an issue on parse-server requesting that improvement please?
Thanks @rochdev ; I'll draw some inspiration from the `http` tracing plugin.
That's a super neat feature those diagnostics channels! I assume we want both implementations and patch based on the `node.js` and `undici` versions?
OK that works for me @rochdev , we're not even on node 16 yet! I planned to get on that next week.
Got this https://github.com/nodejs/undici/pull/1053 patch done for undici for better compatibility. Outside the `request` call, patching all other API's (pipeline, stream etc...) is proven to be cumbersome. The implementation through the...
@rochdev , what do you think about this:https://github.com/nodejs/undici/pull/1053#issuecomment-934560506?
@rochdev @bengl I've open the PR above to gather initial feedback around the implementation. Notably, the `next` tests seem to fails because of the inclusion of the `diagnostic_channels` module. Any...
Interesting! I've rebased, let's see how it goes!
@JustinTRoss I haven't had a chance to actually move forward with a new implementation; the monkey patching look very complex given undici's architecture; there are multiple APIs that leverage dispatchers...
@Grmiade yep agreed - I haven't had the chance to improve on the current design and address the comments.