Markus Kohlhase

Results 269 comments of Markus Kohlhase

> Anyway, that example is somewhat redundant, as that should be a use-case for the new `interval` view now. But now I added the "abort handle", that might be specific...

> Apart of nits, looks good, nice job with the `ShutdownSignal`. thank you 😊

@Philipp-M I cherry-picked [your commit](https://github.com/Philipp-M/xilem/commit/f7d351ff970556c84560327cf5cab2d9cf0eb7c7#diff-4e6ca7cc46c5f661102bd9d26f1a9c10f0d729c3b2157affe3eb92beb23830c5) and tried to adjust it to the current code base. To be honest, I haven't figured it all out yet :see_no_evil: Could you imagine helping...

@alexnest would you mind to create a PR with that info?

@TheToddmeister I'm not quite sure what you mean exactly. Can you give me an example in JS?

Feel free to open a PR

Are you sure that the server also sends back `0x03`? The check is generally done here: https://github.com/slowtec/tokio-modbus/blob/4a061c4d0f16835606b85fb2a62285e3967cba2c/src/service/rtu.rs#L84-L94

> Would you consider Hubris and Embassy good additions to this list? yes of course :smile: Would you mind to open a PR?