pongo2 icon indicating copy to clipboard operation
pongo2 copied to clipboard

make tags and filters private for templateSet

Open honmaple opened this issue 1 year ago • 4 comments

TemplateSet add tags and filters variable, and remove global variable, RegisterTag and RegisterFilter will change DefaultSet.tags and DefaultSet.filters. After modification, different function but same name can be added for different templateSet

honmaple avatar Jun 26 '23 05:06 honmaple

This behaviour would be super useful for a project I'm working on that uses pongo2 internally. I think it's a better, safer design for the package. Ideally there would be no global variables, except for convenience (e.g. defaults)

Currently due to the global nature of registering tags/filters, a user of my package may end up introducing regressions if they themselves use pongo2 as well.

iamcalledrob avatar Oct 25 '23 16:10 iamcalledrob

I agree about usefulness of this feature - @flosch is there a chance that we can get this merged any time soon? Think at least 3 people are itching to be using it!

draganm avatar Oct 25 '23 20:10 draganm

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 30 '23 03:10 sonarqubecloud[bot]

@flosch I'd love to see this functionality get merged, is there anything we can do to help?

iamcalledrob avatar Dec 28 '23 15:12 iamcalledrob