arel icon indicating copy to clipboard operation
arel copied to clipboard

Example app should default to debug=True

Open pauleveritt opened this issue 3 years ago • 4 comments

The example doesn't work out-of-the-box, as changes aren't reloaded. IMO, this line in examples/server/settings.py should default to True:

DEBUG = config("DEBUG", cast=bool, default=False)

As background, I was working very slowly on writing just this very thing: a reloader more sophisticated/performant than livereload, based on the watchgod changeset approach, in Starlette. But learning asyncio was really slowing me down. Thanks!

pauleveritt avatar May 01 '21 12:05 pauleveritt

@pauleveritt Hello! This suggestion sounds appropriate to me. Happy to review a PR if you're down for it.

florimondmanca avatar May 01 '21 13:05 florimondmanca

Yep, I'm down for it. Mind if I (in another PR) make a second example which takes the changeset and only changes things in the tree that were add/edit/delete?

pauleveritt avatar May 04 '21 12:05 pauleveritt

Not sure what that means exactly, but as a separate PR, sure. :)

florimondmanca avatar May 05 '21 12:05 florimondmanca