Florian Voutzinos

Results 27 comments of Florian Voutzinos

The issue has been documented here: https://github.com/florianv/exchanger/blob/master/doc/readme.md#configuration You need to setup the curl client to follow location: ``` $options = [ CURLOPT_FOLLOWLOCATION => true, ]; $client = new CurlClient(null, null,...

Yes it would be an "Object Http Mapper"

Yes. Setters are only useful for typehinted params, but then it's a question of consistency, i.e if I use a setter once, maybe I should use them everywhere. For example...

Yes : 1) It adds a dependency, people need to define it 2) Absolute file paths cannot be passed everywhere

For example here : https://github.com/joomla/joomla-framework/blob/436253110c9e47c8cbfb9a6b2780e812480a31ab/src/Joomla/Language/Language.php#L197 (Well it's not a good example because the path is hardcoded) but you would need to change the constant just before calling the constructor to...

@piotr-cz I think it would be better to pass directly the full path to the directory where we can find language files / overrides

@morloderex Thanks for your PR :) I would maybe instead introduce a `CacheResolver` so everyone could customize the strategy based on their caching needs and pass it as a constructor...

Also some other classes must be changed, for example https://github.com/joomla/joomla-framework/blob/staging/src/Joomla/Form/Rule.php#L61 depends on SimpleXMLElement

A simple interface like this could replace the Rule class I think ``` php

@dongilbert @eddieajau Also we need to add the ability to load namespaced fields and rules maybe with a '.' as separator ? ``` xml ```