tins icon indicating copy to clipboard operation
tins copied to clipboard

Begin using SemVer

Open ppeble opened this issue 9 years ago • 2 comments

I recently updated via the coveralls gem and I ran into an issue where your most recent changes meant that you no longer supported jruby. I request that you switch to http://semver.org/ so that upstream projects can version accordingly so that this does not occur. I will be making a similar request of the coveralls project.

Thanks!

ppeble avatar Jul 31 '16 08:07 ppeble

Can you tell me what actually happened? JRuby is still supported:

(flori@workhorse:tins [master] ☯ ↳130)$ ruby -v -S rake 2>&1 | grep -E '100%|jruby 9'
jruby 9.0.5.0 (2.2.3) 2016-01-26 7bee00d Java HotSpot(TM) 64-Bit Server VM 25.45-b02 on 1.8.0_45-b14 +jit [darwin-x86_64]
100% passed

flori avatar Aug 01 '16 09:08 flori

I apologize, I realize that my original issue was too vague. I should have stated that it was specifically jruby 1.7.x. Here is what I was seeing in my tests:

$ bundle install --jobs=3 --retry=3 --path=${BUNDLE_PATH:-vendor/bundle}
Fetching gem metadata from https://rubygems.org/
Fetching version metadata from https://rubygems.org/
Resolving dependencies....
Using bundler 1.12.5
Installing coderay 1.1.1
Installing rake 11.2.2
Installing json 2.0.2
Installing docile 1.1.5
Installing simplecov-html 0.10.0
Installing tins 1.11.0
Gem::InstallError: tins requires Ruby version >= 2.0.
Installing ffi 1.9.14
Installing thor 0.19.1
Using holidays 4.6.0 from source at `.`
Installing metaclass 0.0.4
Installing method_source 0.8.2
Installing power_assert 0.3.0
Installing slop 3.6.0
Installing simplecov 0.12.0
An error occurred while installing tins (1.11.0), and Bundler cannot continue.
Make sure that `gem install tins -v '1.11.0'` succeeds before bundling.

Here is the full Travis CI log for jruby-1.7.20: https://travis-ci.org/holidays/holidays/jobs/148640105

Perhaps I am misunderstanding? I took these to mean that jruby 1.7 is no longer supported since apparently jruby reports itself as < 2.0 ruby. I am not a jruby expert, though, so it's entirely possible that I am misunderstanding.

Also, just so I am not unintentionally vague: tins dropping support for < 2.0 is fine, I was just surprised because of the lack of a major version bump.

Let me know if I am missing something. Thanks!

ppeble avatar Aug 02 '16 03:08 ppeble