rmtoo icon indicating copy to clipboard operation
rmtoo copied to clipboard

Rflo/master

Open kown7 opened this issue 4 years ago • 3 comments

  • using flit to package and upload to pypi
  • rmtoo-contrib-dir to get contrib/ directory, no need for environment variables anymore.

kown7 avatar Sep 28 '20 19:09 kown7

Codecov Report

Merging #39 into master will increase coverage by 0.14%. The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   90.81%   90.95%   +0.14%     
==========================================
  Files         110      110              
  Lines        4703     4799      +96     
==========================================
+ Hits         4271     4365      +94     
- Misses        432      434       +2     
Impacted Files Coverage Δ
src/rmtoo/inputs/RDepConstraints.py 100.00% <ø> (ø)
src/rmtoo/inputs/RDepDependsOn.py 100.00% <ø> (ø)
src/rmtoo/inputs/RDepMasterNodes.py 100.00% <ø> (ø)
src/rmtoo/inputs/RDepNoDirectedCircles.py 100.00% <ø> (ø)
src/rmtoo/inputs/RDepOneComponent.py 100.00% <ø> (ø)
src/rmtoo/inputs/RDepPriority.py 100.00% <ø> (ø)
src/rmtoo/inputs/RDepSolvedBy.py 100.00% <ø> (ø)
src/rmtoo/inputs/ReqCE3.py 100.00% <ø> (ø)
src/rmtoo/inputs/ReqClass.py 100.00% <ø> (ø)
src/rmtoo/inputs/ReqConstraints.py 100.00% <ø> (ø)
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 633c470...8ef7ff6. Read the comment docs.

codecov-commenter avatar Sep 28 '20 19:09 codecov-commenter

Hello! Thanks for providing the changes / pull request. I'm sorry, but I'm not able to merge this: it is just too big. A pull / merge request should implement one feature / problem. What I see here is that many different aspects are merged into one request: some of them I'll not accept (or at least we should discuss them first). Example: you remove files which I (still) need. Please split up the changes feature-wise and provide appropriate pull requests.

florath avatar Sep 30 '20 05:09 florath

It's basically just one feature: automated build/deploy using flit. I hardly see a point in splitting these commits. A git merge --squash isn't an option as it would break the tests again.

  • fhe first 5 commits are basic support for flit
    • Setting FLIT_PASSWORD in travis to upload automatically.
    • Only tagged builds will be uploaded.
  • 83223b5 to 86eaf85 removes setup.py support, as it duplicates most/all information in pyproject.toml
  • the last 8 commits put the contrib/ directory back into the distribution. This feature didn't work as intended.

kown7 avatar Oct 02 '20 19:10 kown7