oryol icon indicating copy to clipboard operation
oryol copied to clipboard

glm changed the way there structs are initialized

Open mgerhardy opened this issue 7 years ago • 2 comments

stuff like glm::rotate(glm::mat4(), [...] won't work anymore in future version of glm - you have to use the glsl call glm::mat4(1.0f) here, the same is true for stuff like glm::vec3() - this is no longer initialized to zero. I've seen this quite a lot over the codebase. So you might be interested in this fact. You still some time left until latest glm versions gets into the repositories - but still...

mgerhardy avatar Aug 16 '17 18:08 mgerhardy

these might help to find some of the relevant locations.

ag "glm::?mat. [a-zA-Z]+;" src/
ag "glm::?vec. [a-zA-Z]+;" src/
ag "glm::?quat [a-zA-Z]+;" src/
ag "glm::?vec.\(\)" src/
ag "glm::?mat.\(\)" src/
ag "glm::?quat\(\)" src/

mgerhardy avatar Aug 16 '17 19:08 mgerhardy

Ok thanks for the heads up :) glm is in a submodule in fips-glm, so it won't break automatically even for new check-outs. I'm not sure yet when I will update glm to latest, but at least I know now what's the reason if everything suddenly breaks ;)

floooh avatar Aug 16 '17 21:08 floooh