ruby-jmeter icon indicating copy to clipboard operation
ruby-jmeter copied to clipboard

Change Fixnum to Integer

Open nicoalonsop opened this issue 4 years ago • 4 comments

From ruby 2.4 Fixnum is deprecated in favor of Integer so that I changed all Fixnum to Integer.

Fix: https://github.com/flood-io/ruby-jmeter/issues/147

nicoalonsop avatar Mar 26 '20 20:03 nicoalonsop

@timkoopmans I think this PR is fine since the constants Fixnum and Bignum are just aliases for Integer from Ruby 2.4 and also Integer already exist on Rubies < 2.4 so it's backwards compatible.

Do you see any issue with the PR itself?

FLarra avatar Apr 06 '20 20:04 FLarra

@timkoopmans is there anything we can do to move this PR forward? Thanks

FLarra avatar May 23 '20 01:05 FLarra

Is this gem maintained anymore? @timkoopmans

jlurena avatar Jul 28 '24 15:07 jlurena

No sorry, Flood IO has been retired and related work.

timkoopmans avatar Jul 28 '24 21:07 timkoopmans