file:// URLs in tabs cause synchronization failures

[unode]

Which version of floccus are you using?

5.1.4

How many bookmarks do you have, roughly?

~300

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Firefox 125.0.3

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

Owncloud 10.14.0

Describe the Bug

Synchronizing tabs after opening a pdf in Firefox (click example and "Open with Firefox") causes an Illegal URL error. When opening the PDF directly in the browser, the URL looks like file:///tmp/mozilla_username0/filename.pdf causing the error when synchronized to another browser.

Expected Behavior

The file:// URL should be used as-is. If pointing to a file that doesn't exist, the equivalent 404 page should be shown. If the file:// actually exists on disk on all synchronized browsers, it should simply restore the tab and open the existing file.

To Reproduce

1. Visit https://www.adobe.com/support/products/enterprise/knowledgecenter/media/c4611_sample_explain.pdf
2. Click in "Open with Firefox" which should make the PDF open in Firefox using pdf.js.
3. The URL should contain file://`
4. Synchronize tabs using floccus.
5. In the second browser synchronize tabs. You should see the Debug error.

Debug log provided

• [ ] I have provided a debug log file

[github-actions[bot]]

Hello :wave:

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. I'm Marcel and I created floccus and have been maintaining it ever since. I currently work for Nextcloud which leaves me with less time for side projects like this one than I used to have. I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it. Until then, please be patient. Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue Cheers :blue_heart:

[khankul]

Still present as of Floccus 5.2.5, using Git. The problem with that error is that when encountering file links, it goes into a cycle of trying to open the last batch of tabs it was working on, resulting in multiple duplicates, whose number rises pretty fast. Since it queries the sync attempts one after another, it can only be stopped at once by removing the profile. My current remedy is to remove the file links from the XBEL file, and sync manually to prevent file links from ending up in it.

[marcelklehr]

I can confirm this is a limitation of the tabs API on firefox:

For security reasons, in Firefox, [the URL for new tabs] may not be a privileged URL.

Will have to do what you currently do manually: Filter out the privileged URLs :/

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.