floccus icon indicating copy to clipboard operation
floccus copied to clipboard

This url will cause sync error

Open Sorata opened this issue 2 years ago • 3 comments

Which version of floccus are you using?

4.14.0

Sync method

{"label"=>"WebDAV"}

Which browser are you using? In case you are using the Android App, specify the Android version please.

Firefox 100.0.2

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

Url:https://blog.csdn.net/weixin_28987001/article/details/116655417 The title:linux删除0字节的文件,如何在linux中删除许多0字节的文件?_解说柯基~~~的博客-CSDN博客

The string after 柯基, will cause sync error: Syncing failed with An invalid or illegal string was specified

Expected Behavior

Sync OK.

To Reproduce

Just add it to bookMark and sync.

Debug log provided

  • [ ] I have provided a debug log file

Sorata avatar May 31 '22 07:05 Sorata

I can reproduce it with same version of Firefox, but only if I modify the bookmark and give it the title provided in your post.

However, if I directly create a bookmark from the link you provided, Firefox will automatically use a different character than the one (�) that you gave, and then syncing works.

And if you use Chrome when bookmarking the link, you can notice that Chrome will automatically and simply erase the symbol on the title.

Github also cannot make difference between those symbols. (I suppose the symbol I see in your comment is not the same than the one you wrote, and github changed it, no ?)

So I guess that you reached a problem that even browsers aren't able to handle without changing the title.

Does it happen a lot to you, that you bookmark or uses websites with this symbol on the title ? or it was the only one ever ?

Just for pleasure : In your language, what does this symbol (or word) mean ? because of course I cannot see it.

pinpontitit avatar Jun 02 '22 21:06 pinpontitit

I don't know either, I just suddenly found out that I couldn't synchronize, so I spent time locating the cause of the problem, and found that this url caused an exception. It doesn't matter if this problem is not fixed, after all, the title of the bookmark can be manually adjusted.

Sorata avatar Jun 04 '22 09:06 Sorata

Right. However it's true that the Error message could be more explicit for the user.

Like this they know that they can fix it themselves by changing the title.

For example, before all the technical content (if this content is truly needed by the user):

"There is 1 or more invalid characters in the bookmark title, please change or remove those".

pinpontitit avatar Jun 05 '22 18:06 pinpontitit

I cannot reproduce this with latest firefox.

marcelklehr avatar Mar 22 '23 09:03 marcelklehr

Hi, I have the same bug with another asian URL I can reproduce this bug with Librewolf 116.0-1 + Firefox 102.13.0esr on debian 12

https://rtrp.jp/articles/43475

Firefox

Firefox assigned bookmark name: "《長崎》美しき日本を再発見!長崎のフォトジェニックな絶景スポット5選 | RETRIP[リトリップ]"

Firefox Library's screenshot

Screenshot from 2023-08-05 11-04-47

In my case, If you look in the page at the article's title after "見!" it seems the character is even missing from it, since Japanese does not have spaces. But if I copy and paste it to gedit then it appears as Firefox. However, at this point, I do not understand what character is.

page title's screenshot Screenshot 2023-08-05 at 11-08-58 《長崎》美しき日本を再発見! 長崎のフォトジェニックな絶景スポット5選 RETRIP リトリップ

Brave

Creating the same bookmark with Brave, the character in the name is replaced with a space and have no issue with floccus. But if you copy the title inside the article to gedit, then it appears.

AnthillSudoku avatar Aug 05 '23 09:08 AnthillSudoku