bookmarks order is wrong

[lazymonkey2]

Which version of floccus are you using?

4.12.0

Sync method

{"label"=>"Google Drive"}

Which browser are you using?

chrome 100.0.4896.75 and edge 100.0.1185.29

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

the order of the bookmarks is wrong. I noticed this in the bookmark toolbar, which contains most of my bookmarks. on chrome I have bookmarks sorted in a certain order, and on edge they are not in the same order (but as far as I know all the bookmarks are correctly synchronized).

Expected Behavior

I want to have the same bookmark order in chrome and edge. If I add a new folder or bookmark, and reorder manually my bookmarks on chrome I expect that the same order will be synchronizrd to edge (and viceversa).

To Reproduce

I believe that the issue is floccus not working correctly on edge. Synching between chrome browsers seems to work correctly.

Here is a screenshot of bookmarks on chrome:

And here is for edge:

On edge the "windows" folder is ok, but the "wls" folder is not: it should be next to "windows". I had issues too with the placement of the three bookmarks on the right.

Please note that the "tj cookie" is a special chrome bookmark: chrome://settings/content/all?searchSubpage=tj-&search=cookie that I use to easily delete the local cookies on my pc (maybe this could be a problem while syncing?).

The other two bookmarks are links to pages of an app running on my pc, and they are similar to this one: https://tj-xxxxxxxxxxxx:9447/srv-rest/login.html

I attach the anonymozed logs for chrome and edge.

chrome.zip

edge.zip

Debug log provided

• [X] I have provided a debug log file

[marcelklehr]

Mh. Does it help to "download & override once"? (Only try if all browsers are in sync already.)

[lazymonkey2]

I've done the download and override, but it didn't fix the order. however in the logs there is this error:

2022-04-06T09:30:13.716Z Failed to execute REORDER: Failed to reorder folder 24909: Index out of bounds. Moving on. 2022-04-06T09:30:13.716Z [b4bc489c94b9919ac857078fbfd423ea4bb30ba7489abcbf14374f9e49f9b5c9] 2022-04-06T09:30:13.843Z Failed to execute REORDER: Failed to reorder folder 24920: Index out of bounds. Moving on. 2022-04-06T09:30:13.843Z [bc1b1f1380c84383540224c8fd3ecc1f43aebf8ffc56edbd33ec37e1e813e37c] 2022-04-06T09:30:13.974Z Overriding title of built-in node 1 Favorites bar => Bookmarks Bar 2022-04-06T09:30:14.053Z onSyncComplete 2022-04-06T09:30:14.268Z No changes to the server version necessary 2022-04-06T09:30:14.764Z Successfully ended sync process for account Google Drive: bookmarks.xbel

I think that in case of errors like "Index out of bounds" floccus should give a warning to the user, not fail silently.

I have attached the logs (I have done the override two times, so there are two logs) anonymized_logs_after_override.zip

The "wls" folder in the log is this: 6c6657c0016d678488b8e91d28d5876935025302eb3e7d790f239ee2f52002a2

[lazymonkey2]

I have investigated a little, and have found differences in the bookmarks of edge and chrome.

1. on edge in the folder 24909 and 24920 there are two missing bookmarks, which are present in chrome. Maybe during the sync these two bookmarks are detected, but edge fails to create them, and then I get the index out of bounds error, and the reorder could be failing because of that.
2. for unknown reasons in chrome there is a bookmark "edge://policy/" that is missing in edge! Since it starts with edge:// it was added in edge for sure, then it was synced to chrome (possibly in a previous version of floccus that didn't block these special bookmarks) and then I don't know what happened but it's strange that now it is missing in edge. Probably there could be similar issues for special bookmark for Brave, Vivaldi, and others.

[FrankBKK]

I have the same problem - I use the Firefox bookmark toolbar on my main pc as upload only reference and all other pc and browsers (Firefox, Opera, Chrome, Edge) as download only so they are in sync with my main browser - since the latest Floccus updates the sorting is all messed up on the download clients and I had to resort to another bookmark sync and disabled Floccus auto-sync. Hope this can be fixed soon ...

[pinpontitit]

Same for me. Sometimes after sync, the bookmarks on the downloading platform are all messed up. As I dont have so many, I sort them manually but if I had a lot I would be unhappy.

[lazymonkey2]

In my case after sync there are some missing bookmarks. I suspect that the wrong order is a consequence of these missing bookmarks. Can you open the logs and look for some error like "index out of bounds exception" ? Maybe you could also upload here your anonymized logs, to help the author resolving the issue.

[pinpontitit]

Ok here's the log : floccus-4.13.1-2022-05-01.log

but now I am certain: I don't have any bookmark that is deleted, but the bookmarks are sorted differently sometimes.

Once again a bookmark which in my browser I did put in fifth position, had become first position in Android. The bookmark was in last position in my browser(because I had just saved it), and I decided to manually put it in fifth position. When I synced in Android the bookmark appeared in first position.

And now on my browser, because of the sync mistake on android, the bookmark is also in first position.

but all the other bookmarks are good(I think... i was focused on this one)

Generally the positions are respected and there's only one at a time, when I sort in my browser, that randomly changes position in Android.

thats strange.

More details here: https://github.com/floccusaddon/floccus/discussions/1091#discussioncomment-2667502

[Eyion]

So has the problem been solved

[pinpontitit]

It happened again tonight. I opened Floccus 10 min ago and discovered that the bookmarks order had changed since I had opened it maybe 20 minutes ago. So thats why I did notice the change.

I'm pretty sure what happened is: the 2 last bookmarks on my bookmark list were moved in first position. I did add those bookmarks yesterday in my computer browser so they were in last position of my toolbar.

Now they are in first position of (Android) bookmarks, so I guess that tomorrow when I will sync my computer browser floccus, they will be moved to the first position of my toolbar.

I am sure they were at the end in browser. But I am not sure they were already synced in Android, and after a second or third sync, Android moved them to first position. Or if they were'nt synced and the first sync made them appear to first position.

I wish I had look with more attention... but thats life.

I cannot provide debug logs for the reason stated in my other issue #1181

thanks

[lazymonkey2]

I tested again using v4.14.0 but still doesn't work. After sync I also have missing bookmarks, but I don't know if the wrong order is related to these missing bookmarks.

[pinpontitit]

Happened yesterday:

I spent all my time in Chrome and added some bookmarks.

At the end, I went on Firefox and, as intended floccus automatically synced.

Here's what was my Bookmark bar in Chrome:

And here's what was synced in Firefox:

Same number of bookmarks.

One bookmark ("MDN") was replaced by "gitflow commands". So now I have twice the same bookmark " gitflow commands", and a disappeared MDN bookmark.

And of course the order isnt respected.

I forgot to download log yesterday, if I go download today will it still contains infos about yesterday ?

[marcelklehr]

One bookmark ("MDN") was replaced by "gitflow commands".

That's concerning. Did the URL also change on this bookmark or is it still pointing to MDN?

I forgot to download log yesterday, if I go download today will it still contains infos about yesterday ?

You can try. It might not contain yesterday's entries anymore.

Can you check whether your XBEL file also contains the mistakes?

[FrankBKK]

same problem here - the sorting is just garbled up - I sync between many PC (with one being the master) and I get now different results on different PC - really annoying - as a result (hopefully) temporarily I now have to use another sync SW

[FrankBKK]

btw - there is an easy way to test that - in the bookmark toolbar of any browser add a new entry and rename it with the current date - its easy to spot when you sync/download on another PC that it changes position - happens on 100% of my computers

[marcelklehr]

Thanks! I will try to replicate.

[marcelklehr]

I was able to reproduce and find the bug.

[marcelklehr]

The problem was only present in the root of the synced folder due to a copy-paste error :see_no_evil:

[marcelklehr]

I will do a release shortly.

[FrankBKK]

so glad that you could fix it - look forward to the update so I can use it again - except that bug it is a great tool and better than any other sync utility I tried so far

[pinpontitit]

The problem was only present in the root of the synced folder due to a copy-paste error :see_no_evil:

Hi The disorder of bookmarks continue happening for me in the root folder (i.e. "Bookmarks bar" for me).

I'm quite sure the Android version of Floccus is in cause. I can add, remove, sync from one browser to another browser, without the order being change. But sometimes after syncing with Android, if I come back to browser, the last 5 bookmars on my bookmark bar comme yo the front.

It seems to happen after syncing in android, directly the next sync on browser.

Maybe it happens only when new bookmarks were added, if they were old bookmarkd the order is not compromise.

I'm not 100℅ sure but I'm sharing anyway if it can help debug.

Can I ask you something: which file contains the code responsible for syncing and sorting bookmarks when syncing in Android ?

thanks

[marcelklehr]

I'm not 100℅ sure but I'm sharing anyway if it can help debug.

Thank you! I'm happy about any hints and help!

I'm quite sure the Android version of Floccus is in cause.

Does it help to "sync down" once on Android to get the intended order onto your android device and then set sync strategy back to merge?

which file contains the code responsible for syncing and sorting bookmarks when syncing in Android ?

Technically, the code is exactly the same on android as in the browser:

The bookmarks tree is loaded into memory first. Then the sync algorithm compares the server tree and the local tree and computes the changes to make to them.

[marcelklehr]

ping @pinpontitit

[pinpontitit]

Hi 😀

Does it help to "sync down" once on Android to get the intended order onto your android device and then set sync strategy back to merge?

I never tried because I was affraid to lose the new bookmarks added to Android if I did that...

If I add bookmarks in Android, and then after, in order to sync Android with browsers, I start by doing a "sync down" (or pull), am I right that this will erase all the new bookmarks ?

By the way, the bookmarks order problem happened again few days ago: I spent most of the time on my computer, syncing between firefox and chrome, and then when, after almost a month without syncing with my phone, I synced in Android, all the bookmarks were saved in disorder. All of that to say I'm quite positive its an Android sorting problem.

[marcelklehr]

If I add bookmarks in Android, and then after, in order to sync Android with browsers, I start by doing a "sync down" (or pull), am I right that this will erase all the new bookmarks ?

Ah, that might be a problem, yes :/

[pinpontitit]

Sorry, Is there something I could do to help debug this ? Any procedure you're thinking of ?

Would it help if I did the same thing (adding bookmarks in Android and browsers without syncing Android, during 1 week, and then sync in Android) and if the problem occurs again, post here the logs (even if I doubt there's infos in the logs about the ordering process) ?

[marcelklehr]

It could help, yes, make sure to upload the logs to my nextcloud, though, if you want privacy ;)

[neoKushan]

Hi, I am not sure if this is related or not to the above issue. I am a new user to Floccus, syncing via nextcloud. My intention is to sync bookmarks between Firefox and Chrome.

Everything works but folders are out of sync. Bookmarks themselves are in the correct order, but any folders are going to the bottom instead of their correct order.

The bookmarks within folders are in the correct order, it's just the folders themselves.

I am not syncing with Android or anything yet.

[marcelklehr]

Hi @neoKushan, please open a new issue and fill out the details about your setup so I can help better and judge if this is indeed a duplicate :)

[neoKushan]

@marcelklehr Thanks for the response! Weirdly enough, this issue has just abruptly fixed itself. I promise I didn't do anything different, I had given up trying to fix it while waiting for a response and during the next automated sync it just reordered everything. Apologies for the bit of a time waste, but if it reproduces I'll open a new ticket.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.