psa_car_controller icon indicating copy to clipboard operation
psa_car_controller copied to clipboard
verified publisher icon flobz

feat: make preconditioning failure available (in API)

Open gernot-h opened this issue 1 year ago • 3 comments

The preconditioning element has an interesting field called "failureCause" which reports error conditions like opened doors, battery low state etc preventing the preconditioning to run. These errors are interesting, so make them available in our API.

This field was removed in 619cefd4, not sure why, so add it again.

Fixes #760.

gernot-h avatar Feb 15 '24 20:02 gernot-h

You can now see the failureCause in the API:

grafik

gernot-h avatar Feb 15 '24 20:02 gernot-h

thanks ! :)

flobz avatar Feb 24 '24 10:02 flobz

@flobz, I rebased this to master now, so the tests are all green again. I also just re-applied this change to my local installation, et voila, it told me the boot of our car (again) wasn't closed correctly.

So I would really love to see this merged into master ;-). If there's anything I can improve/prepare to help you with reviewing/merging, let me know. :-)

gernot-h avatar Mar 05 '24 21:03 gernot-h

lgtm thanks

flobz avatar Mar 19 '24 19:03 flobz