psa_car_controller icon indicating copy to clipboard operation
psa_car_controller copied to clipboard

ABRP HTTPS warning in Log

Open kurim opened this issue 1 year ago • 3 comments

Describe the bug After adding ABRP log shows warning message

To Reproduce Steps to reproduce the behavior:

  1. add ABRP Token + Enable ABRP
  2. while contacting ABRP API
  3. Does it persist after restarting the program? Yes

Config file Give the anonymize content of the config file

Environment (please complete the following information):

  • OS: HASO
  • Opel Corsa-e
  • v3.2.0
2023-12-21 21:50:29,510 :: INFO :: 172.30.32.1 - - [21/Dec/2023 21:50:29] "GET /get_vehicleinfo/VINxxxxxxxxx HTTP/1.1" 200 -
/usr/local/lib/python3.9/dist-packages/urllib3/connectionpool.py:1061: InsecureRequestWarning:

Unverified HTTPS request is being made to host 'api.iternio.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings

I guess you can solve it by updating abrp.py at line 55 by replacing this part

                response = requests.request("POST", self.url, params=params, proxies=self.proxies,
                                            verify=self.proxies is None, timeout=TIMEOUT_IN_S)

with

                response = requests.request("POST", self.url, params=params, proxies=self.proxies,
                                            verify=True, timeout=TIMEOUT_IN_S)

In a first test the error is gone

kurim avatar Dec 21 '23 21:12 kurim

the error should appear only if you use proxy no ?

flobz avatar Mar 23 '24 13:03 flobz

I don't use a proxy server just normal router.

kurim avatar Mar 26 '24 18:03 kurim

the error should appear only if you use proxy no ?

So I use NGINX. And what ist the offical way to suppress or to Install the certificate (but i dont like this)

jove01 avatar May 17 '24 15:05 jove01