Florian Bernd

Results 271 comments of Florian Bernd

@pharring I think this feature request is more about having different colors for each guideline. This is e.g. useful if you work on multiple projects with different maximum line length...

I like this addition to Zydis! However I don't think it should ever be an replacement for `ZydisDecoderDecodeFull` as the intended usecase is completely different: `ZydisDisassemble*` -> I want a...

> I would keep `Intel`/`ATT` variants as they are now. I tend to like the other way a little better, as it allows to select sub-styles like MASM as well....

Is there any news regarding this topic? It's a big showstopper for my current project 😞

#### Concept idea: Add an extra layer above the `ZydisDecoderDecodeBuffer` function (care for the double pointer): ```c ZydisDecoderDecodeBufferCached(ZydisDecoder decoder, ..., const ZydisCacheTable* cache, ZydisDecodedInstruction** instruction) // The `instruction` parameter could...

@ZehMatt Yes, it will have several positive side effects. There is some (unintentional) preperation for that in this PR: https://github.com/zyantific/zydis/pull/297/files#diff-c323a181d40c83b95974655308d8abeb7cba5a1e16b6c701fd77b53a35e72f55L1258 After the final unique ID implementation, this field will be...

> Would it make sense to have a mode like `ZYAN_NO_LIBC` that still depends on `memset` and friends being provided by the user? That's essentially what you have to do...

Yes yes, that should already be possible if I remember correctly. Edit: ... by defining the ZYAN_CUSTOM_LIBC macro.

We probably should add a new fuzzer project to test the `ZydisDecoderDecodeOperands()` function with randomly crafted inputs (`context` and `instruction`).

@athre0z > I ran a benchmark and the performance regression is pretty noticeable. :/ That's not nice. Have you been able to profile it? Probably the new branches in `ZydisGetInstructionDefinition`...