frame
frame copied to clipboard
floating
Fix a multiple monitor linux issue
Fixes https://twitter.com/Mudit__Gupta/status/1482324530450530313
I am not 100% sure what the underlying issue is but my current best guess is that https://github.com/electron/electron/issues/8069 causes us to set window size to more than available work area. This leads to unexpected behavior from the window manager.
This fix tries to detect when the bug is being triggered and reduces the height to not overflow.
Sers, can this be merged bls?
Worst case scenario, this reduces the max height of the window by 50 pixels for users that don't use a taskbar (what monster will not have a taskbar?). It makes the app usable for a bunch of other folks like me though. Dual monitor setup on a Linux system is a relatively common setup among the devs.
You can continue looking for a more elegant solution after merging this.
Can you test this with your taskbar set to vertical? We need to check that state and correct either the width, or the the height.
I use a vertical taskbar (woe is me), and I have an issue where the frame wallet renders underneath the vertical taskbar.
Closing this until we get a better idea of the real issue and way forward for Frame here. This solution is likely to have knock-on effects and requires thorough testing across platforms, linux window managers, monitor and desktop configurations - which we currently don't have the bandwidth for. If https://github.com/electron/electron/issues/8069 is responsible then we have to take a similar view to zcbenz in that issue, which is that this is down to the window manager and not really a Frame issue. We'll keep #567 open as a tracker for this.
