frame icon indicating copy to clipboard operation
frame copied to clipboard

Second transaction is not shown to the user

Open PaulRBerg opened this issue 6 years ago • 2 comments

This is exactly the same problem as with https://github.com/MetaMask/metamask-mobile/issues/1249, so I'll just copy paste the answer from there.

Description

Here's my transaction flow:

  1. Approve token
  2. Submit dapp tx

And an approximation for my JavaScript code that creates these two transactions (with ethers.js).

const txs = [];
const tokenApprovalTx = await createTokenApprovalTx();
txs.push(tokenApprovalTx);
const sablierTx = await createSablierTx();
txs.push(sablierTx);

The 2n transaction is picked up by Frame, but it gets stuck in the "See Signer" state. The native app then quickly crashes.

Expected Behaviour

The user should be prompted to sign the 2nd transaction, even if they just previously submitted another one.

Steps

  1. Go to pay.sablier.finance
  2. Log in
  3. Have some Eth and Dai
  4. Tap "Stream Money"
  5. Fill the form with "0.01", any recipient and any duration (caveat: if you don't pay yourself, the money is lost)
  6. Submit form

Environment

  • macOS 10.14.6
  • Firefox 72.0.2
  • Frame.sh 0.2.4 on dekstop
  • Frame.sh 0.2.0 as browser extension

Additional Information

Capture d’écran 2020-02-05 à 23 51 21

PaulRBerg avatar Feb 05 '20 22:02 PaulRBerg

Hi @paulrberg, we've had a lot of releases since 0.2.4 - is this still an issue with the latest 0.5beta.22?

goosewobbler avatar Aug 05 '22 10:08 goosewobbler

Hi @goosewobbler, I don't know, I don't have Frame installed anymore and I'm not able to take some time off to install and test the latest version now. Sorry! It should be fine to close this issue if you can't replicate the behavior.

PaulRBerg avatar Aug 05 '22 14:08 PaulRBerg

@PaulRBerg I just verified this dapp works with the latest 0.6.1 version of Frame (though the wallet connection has some issues with connecting, presumably assuming MetaMask - fixed with a page refresh)

goosewobbler avatar Feb 28 '23 23:02 goosewobbler