flix icon indicating copy to clipboard operation
flix copied to clipboard
verified publisher icon flix

Post `LocalDef` things

Open jaschdoc opened this issue 1 year ago • 6 comments

Once https://github.com/flix/flix/pull/8669 is merged, the following things still need to happen:

  • [ ] Remove LetRec (or deprecate if we decide to hide LocalDef behind a feature toggle)
  • [ ] Update DocAst to accommodate LocalDef / turn LetRec into LocalDef

jaschdoc avatar Oct 04 '24 06:10 jaschdoc

maybe introduce LocalDefSym and LocalDefSymUse?

JonathanStarup avatar Oct 04 '24 08:10 JonathanStarup

maybe introduce LocalDefSym and LocalDefSymUse?

Not so sure about this. I think this will cause massive code duplication...

magnus-madsen avatar Oct 04 '24 08:10 magnus-madsen

I don't think its that bad. They downside currently is that any given ApplyLocalDef can be malformed because its just a varsym and they can be mistaken for eachother

JonathanStarup avatar Oct 04 '24 10:10 JonathanStarup

If we try to introduce LocalDefSym then lets keep it in one self-contained small PR.

magnus-madsen avatar Oct 04 '24 11:10 magnus-madsen

So now LetRec can be removed, yes?

magnus-madsen avatar Oct 08 '24 07:10 magnus-madsen

Yes

jaschdoc avatar Oct 08 '24 08:10 jaschdoc