flipperzero-firmware icon indicating copy to clipboard operation
flipperzero-firmware copied to clipboard

Show the wrong PIN Attempt count on the login screen

Open FireFly7386 opened this issue 1 year ago • 7 comments

What's new

  • It now shows how often you entered the wrong PIN when the flipper is locked

Verification

  • Just enter the wrong PIN and the counter should increase Verification_Show_Wrong_Pin_Attempts

Checklist (For Reviewer)

  • [ ] PR has description of feature/bug or link to Confluence/Jira task
  • [ ] Description contains actions to verify feature/bugfix
  • [ ] I've built this code, uploaded it to the device and verified feature/bugfix

FireFly7386 avatar Mar 04 '24 12:03 FireFly7386

@FireFly7386 you will need review from our UI?UX team first.

@Karator FYI

skotopes avatar Mar 05 '24 06:03 skotopes

Thanks for the interesting idea! It would be better if the text of the attempts were displayed centered at the bottom of the screen, like this: wrong_pin

Karator avatar Mar 06 '24 13:03 Karator

Isn't there the OK button or do you mean to show the attempts if it is currently hidden?

FireFly7386 avatar Mar 06 '24 14:03 FireFly7386

The Text is now down here: Image1

And if you input an arrow it disappers so it doesn´t overlap with any other texts: Image2

It only updates the text on the DesktopPinInputEventResetWrongPinLabel event at the moment, should i make it update at the DesktopPinInputEventUnlockFailed event or are you fine with that?

FireFly7386 avatar Mar 06 '24 19:03 FireFly7386

I'd say that this thing behaves quite strange. @Karator you'd want to see it.

skotopes avatar Mar 07 '24 07:03 skotopes

Are you talking about that even tough attempts = 0 it sometimes executes the if block anyways? Currently trying to figure out why.

FireFly7386 avatar Mar 07 '24 12:03 FireFly7386

did that fix the wierd behavior you were talking about?

FireFly7386 avatar Mar 07 '24 18:03 FireFly7386