flipperzero-firmware icon indicating copy to clipboard operation
flipperzero-firmware copied to clipboard

Skylanders plugin

Open bettse opened this issue 1 year ago • 6 comments

What's new

  • NFC Plugin to detect skylanders and show piece name (Need to add more from https://github.com/silicontrip/SkyReader/blob/master/toynames.cpp)

Verification

  • Load Chest.nfc.txt onto flipper
  • Open NFC app
  • Select Saved->Chest->Info
  • See "Skylanders" and "Imaginite Mystery Chest" (name from https://skylanders.fandom.com/wiki/Imaginite_Mystery_Chests)

Checklist (For Reviewer)

  • [ ] PR has description of feature/bug or link to Confluence/Jira task
  • [ ] Description contains actions to verify feature/bugfix
  • [ ] I've built this code, uploaded it to the device and verified feature/bugfix

bettse avatar Dec 23 '23 19:12 bettse

This seems more than an app than a necessary plugin for the Flipper Zero. If you wish you can check out our Discord to see how to get started with making apps.

Ethanol0001 avatar Dec 26 '23 21:12 Ethanol0001

@Ethanol0001 That's sweet, but I'm Eric Betts. I wrote Seader and I'm co-author of the Picopass app.

bettse avatar Dec 26 '23 22:12 bettse

Ok but that doesn’t mean we need a feature that barely anyone uses anymore that would be better fitted if published to the flipper app store instead.

Ethanol0001 avatar Dec 27 '23 06:12 Ethanol0001

  1. There is almost 0 cost to a feature, even if almost no one uses it.
  2. It clearly can be coded easily as a plugin, and requiring less work on my part than a full app
  3. I think, even if no new versions are coming out, skylanders was popular enough that it is likely examples of NFC the average person could have.
  4. There have been quite a few discussions about skylanders. This person (https://github.com/V0lk3n/Flipper-Skylanders) even went so far as wanting to add their figure specific keys to the global key list back in the day 😁 .

bettse avatar Dec 27 '23 15:12 bettse

@bettse need help?

skotopes avatar Apr 19 '24 10:04 skotopes

Screenshot-20240419-191458

Tested again

bettse avatar Apr 20 '24 02:04 bettse

Hi @bettse , thanks for PR! Just want to confirm: all skylander tags has one password in 0 sector? There is no KDF?

gornekich avatar May 15 '24 17:05 gornekich

Just want to confirm: all skylander tags has one password in 0 sector? There is no KDF?

Sector 0 is always the same; the other sectors are using a KDF

bettse avatar May 15 '24 17:05 bettse

Sector 0 is always the same; the other sectors are using a KDF

Is that KDF known?

gornekich avatar May 15 '24 17:05 gornekich

Is that KDF known?

yeah; it was published at https://nfc.toys/ and I think @noproto has worked on an implementation. That could be added to this later

bettse avatar May 15 '24 17:05 bettse

Is that KDF known?

yeah; it was published at https://nfc.toys/ and I think @noproto has worked on an implementation. That could be added to this later

Got it, thanks!

gornekich avatar May 15 '24 18:05 gornekich