flipperzero-firmware icon indicating copy to clipboard operation
flipperzero-firmware copied to clipboard

cli nfc command does not work after NFC refactor

Open u0d7i opened this issue 2 years ago • 5 comments

Describe the bug.

After NFC refactor, cli "nfc" command shows empty sub-command list and does not work anymore:

+ device: /dev/ttyACM0
starting cli, Ctrl+C to terminate

              _.-------.._                    -,
          .-"```"--..,,_/ /`-,               -,  \ 
       .:"          /:/  /'\  \     ,_...,  `. |  |
      /       ,----/:/  /`\ _\~`_-"`     _;
     '      / /`"""'\ \ \.~`_-'      ,-"'/ 
    |      | |  0    | | .-'      ,/`  /
   |    ,..\ \     ,.-"`       ,/`    /
  ;    :    `/`""\`           ,/--==,/-----,
  |    `-...|        -.___-Z:_______J...---;
  :         `                           _-'
 _L_  _     ___  ___  ___  ___  ____--"`___  _     ___
| __|| |   |_ _|| _ \| _ \| __|| _ \   / __|| |   |_ _|
| _| | |__  | | |  _/|  _/| _| |   /  | (__ | |__  | |
|_|  |____||___||_|  |_|  |___||_|_\   \___||____||___|

Welcome to Flipper Zero Command Line Interface!
Read Manual https://docs.flipperzero.one

Firmware version: dev unknown (82baf1e9 built on 05-12-2023)

>: nfc
nfc
Usage:
nfc <cmd>
Cmd list:

>: 

Reproduction

  1. Connect to FZ serial port
  2. Execute 'nfc' command via cli

Target

7

Logs

No response

Anything else?

tested on latest devbuild ATM (latest releases and rc's have the same issues)

u0d7i avatar Dec 07 '23 12:12 u0d7i

I can confirm - same here on latest versions. Same issue

Tomi2965 avatar Dec 07 '23 17:12 Tomi2965

I don't think it is a bug, after that refactoring the only command available (if the debug flag is active) is "field"

v0lp3 avatar Dec 08 '23 02:12 v0lp3

I don't think it is a bug, after that refactoring the only command available (if the debug flag is active) is "field"

Before refactor it had:

Firmware version: 0.89.0 0.89.0 (5a58004b built on 16-08-2023)

>: nfc
nfc
Usage:
nfc <cmd>
Cmd list:
        detect   - detect nfc device
        emulate  - emulate predefined nfca card
        apdu     - Send APDU and print response 

>: 

And I was relying on apdu one. If this is official and final now, and it 's not going to be re-implemented, would be nice to have a clear statement from the development team on that. I've seen changes in official docs here: https://docs.flipper.net/development/cli , which only refers to: "nfc - NFC factory test app: controls field when the device is in Debug mode." now.

u0d7i avatar Dec 08 '23 11:12 u0d7i

Hello @u0d7i . These commands were removed after refactoring indeed. I am planning to add some cli commands in next release

gornekich avatar Dec 11 '23 10:12 gornekich