flipperzero-firmware icon indicating copy to clipboard operation
flipperzero-firmware copied to clipboard

Use InputKeyRight same way as InputKeyOk in file_browser

Open zverev-iv opened this issue 2 years ago • 0 comments

I think InputKeyRight event must works symmetrically to InputKeyBack in file browser. so we can bind it to same code as InputKeyOk

index e03a032c..a4c50568 100644
--- a/applications/services/gui/modules/file_browser.c
+++ b/applications/services/gui/modules/file_browser.c
@@ -617,7 +617,7 @@ static bool file_browser_view_input_callback(InputEvent* event, void* context) {
             browser_update_offset(browser);
             consumed = true;
         }
-    } else if(event->key == InputKeyOk) {
+    } else if(event->key == InputKeyOk || event->key == InputKeyRight) {
         if(event->type == InputTypeShort) {
             BrowserItem_t* selected_item = NULL;
  1. I think this will help the intuitiveness of the file_browser.
  2. right key is the only one not bound in file_browser.

Is it worth creating a PR?

zverev-iv avatar Jan 05 '23 16:01 zverev-iv