flipperzero-firmware icon indicating copy to clipboard operation
flipperzero-firmware copied to clipboard

Published 20 hours ago • verified publisher icon flipperdevices

Move CSN space to prevent overflow

Open bettse opened this issue 2 years ago • 1 comments

What's new

  • Fix for https://github.com/flipperdevices/flipperzero-firmware/issues/2185
  • Removes space between colon and first CSN byte. Should allow enough room to fit a full 00's CSN.

Verification

  • You could try to reproduce the bug and see it is fixed
  • Alternatively just see the space has been moved and estimate that it'll correct the problem from the bug

Checklist (For Reviewer)

  • [ ] PR has description of feature/bug or link to Confluence/Jira task
  • [ ] Description contains actions to verify feature/bugfix
  • [ ] I've built this code, uploaded it to the device and verified feature/bugfix

bettse avatar Dec 31 '22 04:12 bettse

cc @pcunning

bettse avatar Dec 31 '22 04:12 bettse

Is it ok if we remove spaces between?

skotopes avatar Jan 06 '23 18:01 skotopes

Sorry for the delay, the idea was that the space sometimes was too long, but since it doesn't wrap (as in the failure example) it would be offscreen whitespace. Inelegant. I'm 100% in favor or just removing the spaces. I'll try to get around to that, but feel free to do it and close this out if I'm too slow.

bettse avatar Jan 07 '23 18:01 bettse