flipperzero-firmware icon indicating copy to clipboard operation
flipperzero-firmware copied to clipboard

Published 20 hours ago • verified publisher icon flipperdevices

Fix quoted error for macOS bad-usb

Open elulcao opened this issue 2 years ago • 2 comments

What's new

  • Fixed double quotes that was interpreted as an error.

Screenshot 2022-12-19 at 9 19 39 PM

Verification

  • Executed new demo_macos bad-usb example in a macOS machine.
  • Extra colors comes from my personal zsh configuration.

Screenshot 2022-12-20 at 10 22 23 AM

Checklist (For Reviewer)

  • [ ] PR has description of feature/bug or link to Confluence/Jira task
  • [ ] Description contains actions to verify feature/bugfix
  • [ ] I've built this code, uploaded it to the device and verified feature/bugfix

elulcao avatar Dec 20 '22 04:12 elulcao

The best option will be to fix escaping itself. Can you do that?

skotopes avatar Dec 20 '22 13:12 skotopes

The best option will be to fix escaping itself. Can you do that?

Agree, I removed the redirect so the code it's like before. The problem is the backtick, replacing it with simple quote avoids command substitution.

elulcao avatar Dec 20 '22 16:12 elulcao

Hello @skotopes

Thanks for reviewing the change, 👍 I saw there is an error with "Build / main (pull_request)" about Invalid bucket name "", I couldn't figured out how to fix it nor starting again the check; do you mind letting me know if I have to do something to re-run the check.

elulcao avatar Dec 26 '22 22:12 elulcao

@elulcao nah, that was issue on our side. Now it's fixed.

skotopes avatar Dec 27 '22 07:12 skotopes