flipperdevices
Changes mekare
What's new
I tried to read the relevant documentation but not sure.
cli_cmd_interrupt_received: easier to read cli_getc: easier to read furi_hal_nfc_detect: code simplified a little bit furi_hal_nfc_emulate_nfca: indent skip furi_hal_nfc_listen_rx: data_received removed furi_hal_nfc_transparent_tx_rx: remove useless ret variable furi_hal_nfc_tx_rx_get_flag: defaulting to RFAL_TXRX_FLAGS_CRC_TX_AUTO (=0) furi_string_cat_printf: fixed missing format ibutton_worker_read_comparator: remove double break lfrfid_app: factorize call to DOLPHIN_DEED lfrfid_cli_raw_emulate: move overrun check before FURI_BIT's call lfrfid_cli_raw_read: move overrun check before FURI_BIT's call lfrfid_cli_write: slightly easier to read lfrfid_load_key_data: simplify code lfrfid_save_key_data: simplify code nfc_emv_parser_get_aid_name: change parsed assignation nfc_emv_parser_get_country_name: change parsed assignation nfc_emv_parser_get_currency_name: change parsed assignation protocol_dict_decoders_feed_by_feature: should work as long as ProtocolDecoderFeeds have no side effect protocol_dict_decoders_feed_by_id: should work as long as ProtocolDecoderFeeds have no side effect protocol_dict_decoders_feed: should work as long as ProtocolDecoderFeeds have no side effect protocol_dict_encoder_start: simplified return protocol_dict_render_brief_data: useless return? protocol_dict_render_data: useless return? rfalNfcGetActiveDevice: typo in doc subghz_keystore_raw_encrypted_save: while condition is irrelevant subghz_protocol_decoder_bett_feed: remove reassign same value
Verification
- I intended to not change anything and only rewrite some part of the code I looked at. But I might be wrong
Checklist (For Reviewer)
- [ ] PR has description of feature/bug or link to Confluence/Jira task
- [ ] Description contains actions to verify feature/bugfix
- [ ] I've built this code, uploaded it to the device and verified feature/bugfix
Please verify all your changes again, ensure that you've covered all cases.
@erakem have you also tested all apps and features touched by this PR?
Asking cause it's going to take a lot of efforts on our side and I want to make sure that you actually have tested all those changes that you've made.
It makes perfect sense. I am doing another pass but I am unsure how to correctly test it. So I will review again my code too.
I am currently facing a bug when I try to :
- Read an RFID card
- Write it back without saving it (so "More" > "Write")
- Backlight goes off and stays off <--- ?!
It breaks too when I do this : Saved /
I thought it was my wrongdoing but I seem to get it with both v0.72.1(vanilla from qFlipper) and v0.71.1. I tried to get confirmation from someone else but got no answer.