flipperzero-firmware icon indicating copy to clipboard operation
flipperzero-firmware copied to clipboard

Decode RAW recordings

Open qistoph opened this issue 2 years ago • 10 comments

What's new

Flipper_SubGhz_RAW_decoder-2022-08-26_21 36 43

  • Add decode to the More menu of saved RAW recordings
  • Reuses the SubGhz Receiver View
  • Tweaked this view to support:
    • Live versus File view
    • File progress (instead of Config button) in left bottom
  • Reuses the SubGhz Receiver Info scene
  • Add subghz_file_encoder_worker_get_text_progress

The icon could use a little improvement. Unfortunately I'm not a fluent designer. assets/icons/SubGhz/Decoding_123x52.png

Verification

  • Make a RAW recording of signals supported by available decoders
  • Save the RAW recording
  • From a saved RAW recording, open the More menu
  • Select the Decode option
  • See how Flipper decodes the recorded signals

Checklist (For Reviewer)

  • [ ] PR has description of feature/bug or link to Confluence/Jira task
  • [ ] Description contains actions to verify feature/bugfix
  • [ ] I've built this code, uploaded it to the device and verified feature/bugfix

qistoph avatar Aug 26 '22 19:08 qistoph

Hi. We already have it as a cli command and intentionally decided not to make GUI version of it.

Is there any real life use cases for it?

skotopes avatar Aug 27 '22 12:08 skotopes

@skotopes as for me it's cool to have it in gui

azaitsev avatar Aug 28 '22 16:08 azaitsev

While new protocol support is still being developed, it's a great way to test support for previously recorded codes.

I also feel, like @azaitsev, it should be part of the interface. It will also help beginner users to more easily understand and try-out the relationship between raw recordings and their decoded counter parts.

qistoph avatar Aug 29 '22 14:08 qistoph

Hi. We already have it as a cli command and intentionally decided not to make GUI version of it.

Is there any real life use cases for it? @skotopes

Could you please point to the respective CLI?

white-gecko avatar Aug 29 '22 14:08 white-gecko

Could you please point to the respective CLI?

Checkout my comment in the related issue: https://github.com/flipperdevices/flipperzero-firmware/issues/1638#issuecomment-1223560058

qistoph avatar Aug 29 '22 14:08 qistoph

I definitely like it better in the GUI

RogueMaster avatar Aug 30 '22 17:08 RogueMaster

I second this. Some of us cannot use the cli often and, some of us, cannot use the phone app at all (I do not have enough money to buy a new phone and my old one is not supported :/) The GUI/Onboard possibility to decode raw encodings is awesome imo.

HenryDorsettC4se avatar Sep 02 '22 20:09 HenryDorsettC4se

I also very much like this feature. Unlike the CLI command, it creates an output in a format you can save. With the CLI, you'd have to take the text output and manually convert it into the .sub file format.

For me this feature is useful where you want to limit the time "in the field", for example when recording doorbells, as you can only trigger the bell twice (record raw and then try if the recording works), and then use this UI to decode the recording or even decode it later once the protocol gets added. If you were to start with non-raw recordings and the protocol was unsupported, you increase the number of recording attempts you have to make.

All-in-all for me this is a very nice additition to the FW.

jagotu avatar Sep 06 '22 08:09 jagotu

Hi. Sorry for long delay.

We started to split SubGhz application into specialized apps and can accept this PR as external application. Would you like to try to make this feature separate app?

skotopes avatar Oct 08 '22 18:10 skotopes

I'll move this PR to draft, please un-draft when you complete.

skotopes avatar Dec 10 '22 19:12 skotopes

Any updates on this?

CodyTolene avatar Jul 28 '23 00:07 CodyTolene

@CodyTolene at this point the best option to implement whole thing as external application.

skotopes avatar Aug 24 '23 20:08 skotopes