flipperzero-firmware icon indicating copy to clipboard operation
flipperzero-firmware copied to clipboard

Published 20 hours ago • verified publisher icon flipperdevices

nfc: make dict attack more interactive

Open indutny opened this issue 1 year ago • 3 comments

What's new

  • Progress bar in nfc dict attack mode would tick not just with scanned sectors, but with used dictionary keys

Verification

  • Scan mifare classic key

Checklist (For Reviewer)

  • [ ] PR has description of feature/bug or link to Confluence/Jira task
  • [ ] Description contains actions to verify feature/bugfix
  • [ ] I've built this code, uploaded it to the device and verified feature/bugfix

indutny avatar Jul 26 '22 22:07 indutny

In lieu of closed PR: https://github.com/flipperdevices/flipperzero-firmware/pull/1443

cc @skotopes

indutny avatar Jul 26 '22 22:07 indutny

I realized that I need to make it account properly for the size of user dict. Will un-draft the PR as soon as it is done.

indutny avatar Jul 27 '22 08:07 indutny

Nevermind, that was a night time and I didn't realize that we actually reset the UI when working through a new dict. Force pushed and ready for a review now. Sorry for the noise!

indutny avatar Jul 27 '22 16:07 indutny

Hello @indutny . Nice work, thank you! Please, format sources. You can run ./fbt format. We will merge your PR after 0.63 release (this week)

gornekich avatar Aug 01 '22 19:08 gornekich

TIL! Thanks.

indutny avatar Aug 01 '22 19:08 indutny

Awesome. Thank you!

indutny avatar Aug 04 '22 01:08 indutny