flipperdevices
Flipper Cigarette v0.1.2
Application Submission
- simple cigarette app for flipper zero
Extra Requirements
- none
Author Checklist (Fill this out)
- [ x] I've read the contribution guidelines and my PR follows them
- [ x] I own the code I'm submitting or have code owner's permission to submit it
- [ x] I have validated the manifest file(s) with
python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zip
Reviewer Checklist (Don't fill this out)
- [ ] Bundle is valid
- [ ] There are no obvious issues with the source code
- [ ] I've ran this application and verified its functionality
what fixes are needed? the app works and i completed all the checks
you can check here: https://github.com/flipperdevices/flipper-application-catalog/actions/runs/13073339095/job/36567540777 seems to be icon header include
Error: 10:43:08.252 [E] App ID 'cigarette' in manifest does not match app ID 'flipper_cigarette' from path '/home/runner/work/flipper-application-catalog/flipper-application-catalog/applications/Games/flipper_cigarette/manifest.yml'
seems like you forgot to change app name in second spot
Don't worry, takes me like no time to retry :) Will accept it once I'm done. Sorry for previous delay, been on a sick leave, usually we try to review within 48 hours on workdays
Also we have limitations to markdown, you can find it in docs. It is heavily limited for sake of properly rendering those changes on mobile devices
12:34:07.084 [I] Including description from file /tmp/tmp57msctx7/code/README.md Error: 12:34:07.110 [E] Markdown error: Markdown element 'Html' is not allowed
Seems like you still have markdown elements that are not supported in README.md, what a lot of people do, regarding our catalog is keep 2 separate readme files, one for submission and one for the git repository itself, if it has some extra information, you can check other apps that were approved for examples
i know - didn't get to fix it but today is the day finally!
using a seperate readme file for this makes sense, will do it like that!
thanks!
So close! You forgot to update commit hash, so it is linking it to 2 commits ago!
https://github.com/flipperdevices/flipper-application-catalog/pull/615/files leads to 2 paths: changelog: "@./CHANGELOG.md" description: "@./DESCRIPTION.md"
Description looks fine for me, probably the
tags that are triggering it at https://raw.githubusercontent.com/fuckmaz/flipper_cigarette/refs/heads/dev/CHANGELOG.md
We should actually include the line that triggers the error, will write it down
Okay I got good and bad news lol, good news we fixed other files, bad things, we need to improve logging a bit, when I run the script from above
python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zip
basically I figured it was stumbling on
21:19:08.585 [I] Including description from file C:\Users\user\AppData\Local\Temp\tmpf1zo7onk\code\DESCRIPTION.md <Element 'div' at 0x00000163FFEE4180> [' - multiple Cigarettes\n - cancer progress-bar\n - realistic smoke- and cough-effects', 'special thanks goes out to [jaylikesbunda](https://github.com/jaylikesbunda)!', 'xoxo - maz <3', ''] 21:19:08.608 [E] Markdown error: Markdown element 'Code Block' is not allowed: <markdown.blockprocessors.CodeBlockProcessor object at 0x00000163FFEEF690>
which means it is parsing the readme, so my suggested fix is from few messages back, make a READMESHORT.md or smth, and put only basic description with no html/expanded markdown elements and it should work.
Atleast I disabled the markdown check locally and build completes