flipper-application-catalog icon indicating copy to clipboard operation
flipper-application-catalog copied to clipboard

Ghost ESP

Open jaylikesbunda opened this issue 1 year ago • 7 comments

Application Submission

  • App for interfacing with the Ghost ESP firmware

Extra Requirements

  • Requires an ESP32 GPIO Add-on
  • Requires Ghost ESP Firmware Flashed on ESP32

Author Checklist (Fill this out)

  • [X] I've read the contribution guidelines and my PR follows them
  • [X] I own the code I'm submitting or have code owner's permission to submit it
  • [X] I have validated the manifest file(s) with python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zip

Reviewer Checklist (Don't fill this out)

  • [x] Bundle is valid
  • [ ] There are no obvious issues with the source code
  • [x] I've ran this application and verified its functionality

jaylikesbunda avatar Nov 27 '24 05:11 jaylikesbunda

Greetings! Had to check through the code what is the issue with build. We are matching fields in manifest / .fam file field by field and if they mismatch, we get this error, there are differences in manifest and app.fam files currently.

doomwastaken avatar Dec 05 '24 08:12 doomwastaken

Greetings! Had to check through the code what is the issue with build. We are matching fields in manifest / .fam file field by field and if they mismatch, we get this error, there are differences in manifest and app.fam files currently.

thanks for clarifying! i think i fixed it up but the ofw version will have to be in another branch since the main branch .fam uses the GPIO/ESP folder which i don't think exists in ofw as far as i'm aware

jaylikesbunda avatar Dec 05 '24 09:12 jaylikesbunda

Targets must be "targets: ['all']", that is hardware targets that we have in flipper zero. For example early versions were f6 and current generation is f7. Hence 'all' that is being supported by our build system

doomwastaken avatar Dec 05 '24 10:12 doomwastaken

[E] App ID 'ghost_esp' in manifest does not match app ID 'ghost_esp_app' from path '/home/runner/work/flipper-application-catalog/flipper-application-catalog/applications/GPIO/ghost_esp_app/manifest.yml'

doomwastaken avatar Jan 23 '25 06:01 doomwastaken

[E] App ID 'ghost_esp' in manifest does not match app ID 'ghost_esp_app' from path '/home/runner/work/flipper-application-catalog/flipper-application-catalog/applications/GPIO/ghost_esp_app/manifest.yml'

pretty confused on this. there is no manifest in the repo anymore and the .fam id is ghost_esp, same as in the manifest in this pr

jaylikesbunda avatar Jan 23 '25 11:01 jaylikesbunda

[E] App ID 'ghost_esp' in manifest does not match app ID 'ghost_esp_app' from path '/home/runner/work/flipper-application-catalog/flipper-application-catalog/applications/GPIO/ghost_esp_app/manifest.yml'

pretty confused on this. there is no manifest in the repo anymore and the .fam id is ghost_esp, same as in the manifest in this pr

@jaylikesbunda the dirname for the manifest.yml here is still ghost_esp_app: applications/GPIO/ghost_esp_app/manifest.yml

WillyJL avatar Mar 27 '25 07:03 WillyJL

[E] App ID 'ghost_esp' in manifest does not match app ID 'ghost_esp_app' from path '/home/runner/work/flipper-application-catalog/flipper-application-catalog/applications/GPIO/ghost_esp_app/manifest.yml'

pretty confused on this. there is no manifest in the repo anymore and the .fam id is ghost_esp, same as in the manifest in this pr

@jaylikesbunda the dirname for the manifest.yml here is still ghost_esp_app: applications/GPIO/ghost_esp_app/manifest.yml

thank you for this, really appreciated

jaylikesbunda avatar Apr 04 '25 02:04 jaylikesbunda

whats going on this is mayra

snowflake6688 avatar Apr 27 '25 14:04 snowflake6688

whats going on this is mayra

shh i got it this time

jaylikesbunda avatar Apr 27 '25 16:04 jaylikesbunda

i don't think this is an issue on my end?

jaylikesbunda avatar Apr 28 '25 06:04 jaylikesbunda

Yeah, I am looking into it, seems like bundle issue

doomwastaken avatar Apr 28 '25 06:04 doomwastaken

Regression in the scripts was fixed.

@jaylikesbunda you've ticked the "I have validated the manifest file(s)" checkbox, how come that it's clearly failing on your manifest?

hedger avatar Apr 30 '25 10:04 hedger

Regression in the scripts was fixed.

@jaylikesbunda you've ticked the "I have validated the manifest file(s)" checkbox, how come that it's clearly failing on your manifest?

i don't remember

jaylikesbunda avatar Apr 30 '25 12:04 jaylikesbunda