Ghost ESP
Application Submission
- App for interfacing with the Ghost ESP firmware
Extra Requirements
- Requires an ESP32 GPIO Add-on
- Requires Ghost ESP Firmware Flashed on ESP32
Author Checklist (Fill this out)
- [X] I've read the contribution guidelines and my PR follows them
- [X] I own the code I'm submitting or have code owner's permission to submit it
- [X] I have validated the manifest file(s) with
python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zip
Reviewer Checklist (Don't fill this out)
- [x] Bundle is valid
- [ ] There are no obvious issues with the source code
- [x] I've ran this application and verified its functionality
Greetings! Had to check through the code what is the issue with build. We are matching fields in manifest / .fam file field by field and if they mismatch, we get this error, there are differences in manifest and app.fam files currently.
Greetings! Had to check through the code what is the issue with build. We are matching fields in manifest / .fam file field by field and if they mismatch, we get this error, there are differences in manifest and app.fam files currently.
thanks for clarifying! i think i fixed it up but the ofw version will have to be in another branch since the main branch .fam uses the GPIO/ESP folder which i don't think exists in ofw as far as i'm aware
Targets must be "targets: ['all']", that is hardware targets that we have in flipper zero. For example early versions were f6 and current generation is f7. Hence 'all' that is being supported by our build system
[E] App ID 'ghost_esp' in manifest does not match app ID 'ghost_esp_app' from path '/home/runner/work/flipper-application-catalog/flipper-application-catalog/applications/GPIO/ghost_esp_app/manifest.yml'
[E] App ID 'ghost_esp' in manifest does not match app ID 'ghost_esp_app' from path '/home/runner/work/flipper-application-catalog/flipper-application-catalog/applications/GPIO/ghost_esp_app/manifest.yml'
pretty confused on this. there is no manifest in the repo anymore and the .fam id is ghost_esp, same as in the manifest in this pr
[E] App ID 'ghost_esp' in manifest does not match app ID 'ghost_esp_app' from path '/home/runner/work/flipper-application-catalog/flipper-application-catalog/applications/GPIO/ghost_esp_app/manifest.yml'
pretty confused on this. there is no manifest in the repo anymore and the .fam id is ghost_esp, same as in the manifest in this pr
@jaylikesbunda the dirname for the manifest.yml here is still ghost_esp_app: applications/GPIO/ghost_esp_app/manifest.yml
[E] App ID 'ghost_esp' in manifest does not match app ID 'ghost_esp_app' from path '/home/runner/work/flipper-application-catalog/flipper-application-catalog/applications/GPIO/ghost_esp_app/manifest.yml'
pretty confused on this. there is no manifest in the repo anymore and the .fam id is ghost_esp, same as in the manifest in this pr
@jaylikesbunda the dirname for the manifest.yml here is still
ghost_esp_app:applications/GPIO/ghost_esp_app/manifest.yml
thank you for this, really appreciated
whats going on this is mayra
whats going on this is mayra
shh i got it this time
i don't think this is an issue on my end?
Yeah, I am looking into it, seems like bundle issue
Regression in the scripts was fixed.
@jaylikesbunda you've ticked the "I have validated the manifest file(s)" checkbox, how come that it's clearly failing on your manifest?
Regression in the scripts was fixed.
@jaylikesbunda you've ticked the "I have validated the manifest file(s)" checkbox, how come that it's clearly failing on your manifest?
i don't remember